Skip to content

fix(provisioner/powershell): actually set ProgressPreference to SilentlyContinue - #13712

Open
r3wretrhy wants to merge 1 commit into
hashicorp:mainfrom
r3wretrhy:fix-ps-progress-preference
Open

r3wretrhy wants to merge 1 commit into
hashicorp:mainfrom
r3wretrhy:fix-ps-progress-preference

Conversation

@r3wretrhy

Copy link
Copy Markdown

Description

The powershell provisioner's default execute command sets ProgressPreference with:

Set-Variable -Name variable:global:ProgressPreference -Value 'SilentlyContinue'

Set-Variable -Name takes the variable name, so that looks for a variable literally called variable:global:ProgressPreference and never assigns $ProgressPreference. Scripts still see Continue (issue #13490).

Use $ProgressPreference='SilentlyContinue', matching packer-plugin-sdk's WinRM connect check.

Tested: go test ./provisioner/powershell/

Resolved Issues

Closes #13490

Rollback Plan

If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

No.

@r3wretrhy
r3wretrhy requested a review from a team as a code owner September 19, 2026 12:17
@hashicorp-cla-app

hashicorp-cla-app Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@hashicorp-cla-app

Copy link
Copy Markdown

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Powershell provisioner doesn't set $ProgressPreference='SilentlyContinue'

1 participant