Repository navigation
refactor: reduce complexity of execute_impl in update_wiki_page.rs - #2438
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpdateWikiPageResult::execute_implwas flagged byclippy::too_many_lines(157/100). Clippy'scognitive_complexitylint flagged nothing.resolve_effective_path, which handles path normalization, traversal rejection,path-prefixenforcement andtitle-prefixapplication.update_success_result, which builds the success result from the PUT response.Behaviour and error messages are unchanged.
Complexity:
too_many_lineswent from 157/100 to 124/100. The function is still flagged, but it is much shorter.Validation:
cargo clippy --all-targets --all-features: no errors.cargo test --bin ado-aw update_wiki: 29 passed, 0 failed.cargo testsuite was not run.