From 48dc73b72df5831219fb5d98e83a7601eb2f5642 Mon Sep 17 00:00:00 2001
From: Aditya Thebe <contact@adityathebe.com>
Date: Tue, 8 Sep 2026 13:51:13 +0000
Subject: [PATCH] perf(ci): consolidate resource generation and untagged vet

Full, production and slim jobs repeated resource generation, formatting and untagged vet before executing their own suites.

Keep generation and full vet in Lint, verifying committed Go files, schemas and CRDs before linting. Run the existing suite leaf targets against committed output with envtest provisioning retained. Local make test targets remain unchanged.
---
 .github/workflows/lint.yml | 10 ++++++----
 .github/workflows/test.yml |  8 +++++---
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index 33dfae7ef..58d52aae5 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -21,12 +21,14 @@ jobs:
 
       - name: Generate resources
         run: make resources
-      - name: Verify generated CRDs are committed
+      - name: Verify generated resources and formatting are committed
         run: |
-          if [ -n "$(git status --porcelain -- chart/crds)" ]; then
-            git status --short -- chart/crds
-            echo "::error::Generated CRDs are out of date. Run 'make manifests' and commit the changes."
+          if [ -n "$(git status --porcelain -- '*.go' chart/crds config/schemas)" ]; then
+            git status --short -- '*.go' chart/crds config/schemas
+            echo "::error::Generated resources or Go formatting are out of date. Run 'make resources' and commit the changes."
             exit 1
           fi
+      - name: Vet
+        run: make vet
       - name: golangci-lint
         uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index e7062b244..4ea19a2c2 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -5,6 +5,8 @@ name: Test
 permissions:
   contents: read
 
+# Lint verifies generation, formatting and untagged vet. These suites use the
+# committed generated files so each variant need not repeat that preparation.
 jobs:
   test:
     runs-on: ubuntu-latest
@@ -39,7 +41,7 @@ jobs:
           GITHUB_TOKEN: ${{ github.token }}
         run: make envtest
       - name: Test
-        run: make test
+        run: make gotest
 
   test-playwright:
     runs-on: ubuntu-latest
@@ -160,7 +162,7 @@ jobs:
             postgrest
           GITHUB_TOKEN: ${{ github.token }}
       - name: Test
-        run: make test-prod
+        run: make envtest gotest-prod
 
   clickhouse-e2e:
     runs-on: ubuntu-latest
@@ -212,7 +214,7 @@ jobs:
       - name: Setup
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: make manifests generate fmt vet envtest
+        run: make envtest
       - name: Test
         run: make test-fast