Performance regression after upgrade to 1.16.1

[fggarcia]

Hi @antonmedv @bizywizy Benchmarking 1.16.0 and 1.16.1 i have this result.

version 1.16.0

pkg: github.com/melisource/rule-engine-api/src/api/expression
BenchmarkExprLanguage-8            72614             16105 ns/op           19614 B/op        215 allocs/op
BenchmarkExprLanguage-8            77490             15433 ns/op           19615 B/op        215 allocs/op
BenchmarkExprLanguage-8            77436             15527 ns/op           19616 B/op        215 allocs/op
BenchmarkExprLanguage-8            77794             15175 ns/op           19614 B/op        215 allocs/op
BenchmarkExprLanguage-8            77324             15553 ns/op           19615 B/op        215 allocs/op
PASS

version 1.16.1

BenchmarkExprLanguage-8             3126            333489 ns/op           19492 B/op        214 allocs/op
BenchmarkExprLanguage-8             3728            323352 ns/op           19493 B/op        214 allocs/op
BenchmarkExprLanguage-8             3729            338181 ns/op           19491 B/op        214 allocs/op
BenchmarkExprLanguage-8             3735            321381 ns/op           19494 B/op        214 allocs/op
BenchmarkExprLanguage-8             3744            322084 ns/op           19487 B/op        214 allocs/op
PASS

cpu pprof
version 1.16.0

version 1.16.1

[bizywizy]

Can you please provide the expression which you used in benchmark? I cannot reproduce it.

[antonmedv]

Looks like you include expr.Compile in benchmarks.

If you rerun a program multiple times, do not recompile it.

[fggarcia]

@bizywizy @antonmedv First, thank you!

Okey. I change benchmark only expr.Run(env). If you want to close discussion it's ok.

1.16.0

BenchmarkExprLanguage-8           491038              2419 ns/op            2416 B/op         95 allocs/op
BenchmarkExprLanguage-8           488376              2423 ns/op            2416 B/op         95 allocs/op
BenchmarkExprLanguage-8           488751              2411 ns/op            2416 B/op         95 allocs/op
BenchmarkExprLanguage-8           487338              2427 ns/op            2416 B/op         95 allocs/op
BenchmarkExprLanguage-8           494542              2413 ns/op            2416 B/op         95 allocs/op

1.16.1

BenchmarkExprLanguage-8           488230              2418 ns/op            2404 B/op         95 allocs/op
BenchmarkExprLanguage-8           452661              2450 ns/op            2404 B/op         95 allocs/op
BenchmarkExprLanguage-8           450630              2421 ns/op            2404 B/op         95 allocs/op
BenchmarkExprLanguage-8           446548              2425 ns/op            2404 B/op         95 allocs/op
BenchmarkExprLanguage-8           451249              2424 ns/op            2404 B/op         95 allocs/op