Add System.Net review agent, skill, and folder-scoped instructions#126637
Open
T-Gro wants to merge 6 commits intodotnet:mainfrom
Open
Add System.Net review agent, skill, and folder-scoped instructions#126637T-Gro wants to merge 6 commits intodotnet:mainfrom
T-Gro wants to merge 6 commits intodotnet:mainfrom
Conversation
Generated from the full extraction pipeline using 25,366 expert review
comments across 5,579 PRs from dotnet/runtime and dotnet/corefx,
spanning 2016-2026. Five expert reviewers contributed data.
Artifacts:
- .github/agents/system-net-review.md (reviewing-system-net-code)
24 review dimensions, 87 CHECK items, 12 principles, 5-wave workflow
- .github/skills/system-net-review/SKILL.md (writing-system-net-code)
Implementation guidance with decision trees and code examples;
delegates to @system-net-review agent for structured reviews
- .github/instructions/system-net-{http,sockets,security,quic,common,interop}.instructions.md
Folder-scoped auto-loaded guidance for 6 networking areas
No existing .github/ artifacts were modified.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds GitHub Copilot configuration artifacts to provide System.Net-specific authoring guidance, folder-scoped instructions, and a dedicated networking review agent for dotnet/runtime.
Changes:
- Introduces a new System.Net review agent definition with a structured, dimension-based checklist and workflow.
- Adds a System.Net skill document intended to guide implementation and delegate reviews to the agent.
- Adds folder-scoped instruction files for System.Net subareas (Http, Sockets, Security, Quic, Common, Interop).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/agents/system-net-review.md | New System.Net review agent with principles, dimensions, routing table, and review workflow. |
| .github/skills/system-net-review/SKILL.md | New System.Net authoring/review guidance skill meant to delegate to the agent and provide patterns/decision trees. |
| .github/instructions/system-net-common.instructions.md | Folder-scoped guidance for common System.Net libraries. |
| .github/instructions/system-net-http.instructions.md | Folder-scoped guidance for System.Net.Http/Json/WinHttpHandler. |
| .github/instructions/system-net-interop.instructions.md | Folder-scoped guidance for networking-related interop areas. |
| .github/instructions/system-net-quic.instructions.md | Folder-scoped guidance for System.Net.Quic. |
| .github/instructions/system-net-security.instructions.md | Folder-scoped guidance for System.Net.Security. |
| .github/instructions/system-net-sockets.instructions.md | Folder-scoped guidance for System.Net.Sockets. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
The Dx references in the skill file were mismatched with the agent doc's actual dimension numbering. Rather than fix them (and risk future drift), drop all numeric dimension pointers entirely. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Instruct the system-net-review agent to launch one claude-opus-4.6 sub-agent per dimension in Wave 1, running all dimensions in parallel. Each sub-agent gets the full briefing pack plus its assigned dimension and CHECK items. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated from the full extraction pipeline using 25,366 expert review comments across 5,579 PRs from dotnet/runtime and dotnet/corefx, spanning 2016-2026. Five expert reviewers contributed data.
Artifacts:
No existing .github/ artifacts were modified.