[Runtime Async] Reuse ValueTaskSourceNotifier instance#126622
Open
VSadov wants to merge 2 commits intodotnet:mainfrom
Open
[Runtime Async] Reuse ValueTaskSourceNotifier instance#126622VSadov wants to merge 2 commits intodotnet:mainfrom
VSadov wants to merge 2 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @agocke |
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces per-await allocations in runtime-async by reusing a per-thread ValueTaskSource notifier instead of allocating a new wrapper object each time a ValueTask suspends on an IValueTaskSource.
Changes:
- Replace per-call
ValueTaskSourceNotifierallocations with a[ThreadStatic]cachedValueTaskSourceNotifierinstance. - Introduce a reusable notifier that stores the source, token, and an
OnCompleteddispatcher delegate. - Update CoreCLR runtime-async suspension state to store the concrete
ValueTaskSourceNotifiertype (instead of a removed interface).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/ValueTask.cs | Adds reusable ValueTaskSourceNotifier and updates AsTaskOrNotifier to return a cached notifier for IValueTaskSource-backed ValueTasks. |
| src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs | Updates runtime-async suspension bookkeeping to reference/cast the new ValueTaskSourceNotifier type. |
src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/ValueTask.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/ValueTask.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/ValueTask.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids allocation on every time we need to suspend on a
ValueTaskSource.