Skip to content

chore: Keep legacy trades reads bounded and predictable #4494

Description

@milaforge

Background

GET /api/v1/trades is deprecated, but it can still return all matching trades for an owner or order. The v2 endpoint already has pagination and a clear max limit, so the old endpoint has a less predictable resource profile.

Details

My suggested direction is to keep the endpoint backward-compatible, but make the backend work bounded: apply a conservative default/max limit internally.

Acceptance criteria

  • Decide the intended behavior for bounded v1 trades responses.
  • Add tests for the v1 bound and existing filter validation.
  • Update OpenAPI/docs so integrators know v2 is the paginated path.
  • Add or reuse metrics/logging so capped legacy responses are observable.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions