Skip to content

Service worker registered on every mount, logs the registration object, likely double-registers #351

Description

@Jaydbrown

lib/useServiceWorker.ts registers /sw.js in a useEffect and console.log('Service Worker registered:', registration) on every page load. There is also components/ServiceWorkerRegistrar.tsx doing registration — if both are mounted the SW is registered twice. There is no updatefound / controllerchange handling, so a shipped sw.js change never activates for existing users (the CHANGELOG already notes an "always-caching service worker" incident). Consolidate to one registrar with update handling and drop the console noise.


Filed from a codebase review pass.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Stellar WaveIssues in the Stellar wave program

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions