Remove lifecycle_type_backfill job and related config (#5401)

Author: WeiQuan0605

app/jobs/runtime/lifecycle_type_backfill.rb

@@ -67,10 +67,6 @@ service_operations_delete_stuck_in_progress_retry:
 service_operations_binding_delete_stuck_in_progress_retry:
   frequency_in_seconds: 3600 #1h
 
-# One-off backfill - to be removed in a future version.
-lifecycle_type_backfill:
-  frequency_in_seconds: 3600 #1h
-
 completed_tasks:
   cutoff_age_in_days: 31
 

config/cloud_controller.yml

@@ -28,9 +28,7 @@ class Scheduler
       { name: 'service_operations_create_in_progress_cleanup', class: Jobs::Runtime::ServiceOperationsCreateInProgressCleanup },
       { name: 'service_operations_update_stuck_in_progress_failed', class: Jobs::Runtime::ServiceOperationsUpdateStuckInProgressFailed },
       { name: 'service_operations_delete_stuck_in_progress_retry', class: Jobs::Runtime::ServiceOperationsDeleteStuckInProgressRetry },
-      { name: 'service_operations_binding_delete_stuck_in_progress_retry', class: Jobs::Runtime::ServiceOperationsBindingDeleteStuckInProgressRetry },
-      # One-off backfill - to be removed in a future version.
-      { name: 'lifecycle_type_backfill', class: Jobs::Runtime::LifecycleTypeBackfill }
+      { name: 'service_operations_binding_delete_stuck_in_progress_retry', class: Jobs::Runtime::ServiceOperationsBindingDeleteStuckInProgressRetry }
     ].freeze
 
     def self.queue_names

lib/cloud_controller/clock/scheduler.rb

@@ -46,10 +46,7 @@ class ClockSchema < VCAP::Config
           service_operations_binding_delete_stuck_in_progress_retry: {
             frequency_in_seconds: Integer
           },
-          # One-off backfill - to be removed in a future version.
-          lifecycle_type_backfill: {
-            frequency_in_seconds: Integer
-          },
+
           default_health_check_timeout: Integer,
 
           uaa: {

lib/cloud_controller/config_schemas/clock_schema.rb

@@ -41,7 +41,6 @@
 require 'jobs/runtime/prune_completed_deployments'
 require 'jobs/runtime/prune_completed_builds'
 require 'jobs/runtime/prune_excess_app_revisions'
-require 'jobs/runtime/lifecycle_type_backfill'
 
 require 'jobs/v2/services/service_usage_events_cleanup'
 

lib/cloud_controller/jobs.rb

@@ -25,7 +25,7 @@ module VCAP::CloudController
           service_operations_update_stuck_in_progress_failed: { frequency_in_seconds: 600 },
           service_operations_delete_stuck_in_progress_retry: { frequency_in_seconds: 600 },
           service_operations_binding_delete_stuck_in_progress_retry: { frequency_in_seconds: 600 },
-          lifecycle_type_backfill: { frequency_in_seconds: 500 },
+
           service_usage_events: { cutoff_age_in_days: 5 },
           completed_tasks: { cutoff_age_in_days: 6 },
           pending_droplets: { frequency_in_seconds: 300, expiration_in_seconds: 600 },
@@ -190,12 +190,6 @@ module VCAP::CloudController
           expect(block.call).to be_instance_of(Jobs::Runtime::ServiceOperationsBindingDeleteStuckInProgressRetry)
         end
 
-        expect(clock).to receive(:schedule_frequent_worker_job) do |args, &block|
-          expect(args).to eql(name: 'lifecycle_type_backfill', interval: 500)
-          expect(Jobs::Runtime::LifecycleTypeBackfill).to receive(:new).and_call_original
-          expect(block.call).to be_instance_of(Jobs::Runtime::LifecycleTypeBackfill)
-        end
-
         schedule.start
       end