About CentOS:
The Community ENTerprise Operating System (CentOS) is an Enterprise-class Linux Distribution derived from sources freely provided to the public by a prominent North American Enterprise Linux vendor. CentOS conforms fully with the upstream vendors redistribution policy and aims to be 100% binary compatible. (CentOS mainly changes packages to remove upstream vendor branding and artwork.) The CentOS Project is the organization that builds CentOS.' \
'
For information on CentOS please visit the CentOS website.
' \
'
Note:
CentOS is an Operating System and it is used to power this website; however, the webserver is owned by the domain owner and not the CentOS Project. If you have issues with the content of this site, contact the owner of the domain, not the CentOS project.' \
@@ -235,12 +235,12 @@ def index_page
"\n" \
"
\n" \
"
Welcome to nginx!\n" \
- "\n" \
"\n" \
"\n" \
@@ -269,61 +269,61 @@ def error_page_404
case config.get('beef.http.web_server_imitation.type')
when 'apache'
- return <<-EOF
-
-
-
404 Not Found
-
-
Not Found
-
The requested URL was not found on this server.
-
-
Apache/2.2.3 (CentOS)
-#{("" if config.get('beef.http.web_server_imitation.hook_404'))}
-
-EOF
+ <<~EOF
+
+
+
404 Not Found
+
+
Not Found
+
The requested URL was not found on this server.
+
+
Apache/2.2.3 (CentOS)
+ #{"" if config.get('beef.http.web_server_imitation.hook_404')}
+
+ EOF
when 'iis'
- return <<-EOF
-
-
The page cannot be found
-
-
-The page cannot be found
-The page you are looking for might have been removed, had its name changed, or is temporarily unavailable.
-
-Please try the following:
-
-- Make sure that the Web site address displayed in the address bar of your browser is spelled and formatted correctly.
-- If you reached this page by clicking a link, contact the Web site administrator to alert them that the link is incorrectly formatted.
-- Click the Back button to try another link.
-
-HTTP Error 404 - File or directory not found.
Internet Information Services (IIS)
-
-Technical Information (for support personnel)
-
-- Go to Microsoft Product Support Services and perform a title search for the words HTTP and 404.
-- Open IIS Help, which is accessible in IIS Manager (inetmgr),and search for topics titled Web Site Setup, Common Administrative Tasks, and About Custom Error Messa
-
- |
-#{("" if config.get('beef.http.web_server_imitation.hook_404'))}
-
-EOF
+ <<~EOF
+
+
The page cannot be found
+
+
+ The page cannot be found
+ The page you are looking for might have been removed, had its name changed, or is temporarily unavailable.
+
+ Please try the following:
+
+ - Make sure that the Web site address displayed in the address bar of your browser is spelled and formatted correctly.
+ - If you reached this page by clicking a link, contact the Web site administrator to alert them that the link is incorrectly formatted.
+ - Click the Back button to try another link.
+
+ HTTP Error 404 - File or directory not found.
Internet Information Services (IIS)
+
+ Technical Information (for support personnel)
+
+ - Go to Microsoft Product Support Services and perform a title search for the words HTTP and 404.
+ - Open IIS Help, which is accessible in IIS Manager (inetmgr),and search for topics titled Web Site Setup, Common Administrative Tasks, and About Custom Error Messa
+
+ |
+ #{"" if config.get('beef.http.web_server_imitation.hook_404')}
+
+ EOF
when 'nginx'
- return <<-EOF
-
-
404 Not Found
-
-
404 Not Found
-
nginx
-#{("" if config.get('beef.http.web_server_imitation.hook_404'))}
-
-
-EOF
+ <<~EOF
+
+
404 Not Found
+
+
404 Not Found
+
nginx
+ #{"" if config.get('beef.http.web_server_imitation.hook_404')}
+
+
+ EOF
else
print_error 'Configuration error in beef.http.web_server_imitation.type!'
print_more 'Supported values are: apache, iis, nginx.'
diff --git a/core/main/server.rb b/core/main/server.rb
index d71c7dce19..0ca8c5a351 100644
--- a/core/main/server.rb
+++ b/core/main/server.rb
@@ -12,6 +12,7 @@ module BeEF
module Core
class Server
include Singleton
+
attr_reader :root_dir, :url, :configuration, :command_urls, :mounts, :semaphore
def initialize
@@ -20,7 +21,7 @@ def initialize
@root_dir = File.expand_path('../../../', __dir__)
@command_urls = {}
@mounts = {}
- @rack_app
+ @rack_app = nil
@semaphore = Mutex.new
end
diff --git a/core/module.rb b/core/module.rb
index a6b29fc950..c96552c30b 100644
--- a/core/module.rb
+++ b/core/module.rb
@@ -16,14 +16,14 @@ def self.is_present(mod)
# @param [String] mod module key
# @return [Boolean] if the module key is enabled in BeEF's configuration
def self.is_enabled(mod)
- (is_present(mod) && BeEF::Core::Configuration.instance.get("beef.module.#{mod}.enable") == true)
+ is_present(mod) && BeEF::Core::Configuration.instance.get("beef.module.#{mod}.enable") == true
end
# Checks to see if the module reports that it has loaded through the configuration
# @param [String] mod module key
# @return [Boolean] if the module key is loaded in BeEF's configuration
def self.is_loaded(mod)
- (is_enabled(mod) && BeEF::Core::Configuration.instance.get("beef.module.#{mod}.loaded") == true)
+ is_enabled(mod) && BeEF::Core::Configuration.instance.get("beef.module.#{mod}.loaded") == true
end
# Returns module class definition
@@ -230,10 +230,12 @@ def self.support(mod, opts)
if opts.key?('ver')
if subv.key?('min_ver')
break unless subv['min_ver'].is_a?(Integer) && opts['ver'].to_i >= subv['min_ver']
+
rating += 1
end
if subv.key?('max_ver')
break unless (subv['max_ver'].is_a?(Integer) && opts['ver'].to_i <= subv['max_ver']) || subv['max_ver'] == 'latest'
+
rating += 1
end
end
@@ -303,10 +305,10 @@ def self.parse_targets(mod)
target_config.each do |k, v|
# Convert the key to a string if it's not already one
k_str = k.to_s.upcase
-
+
# Use the adjusted string key for the rest of the process
next unless BeEF::Core::Constants::CommandModule.const_defined? "VERIFIED_#{k_str}"
-
+
key = BeEF::Core::Constants::CommandModule.const_get "VERIFIED_#{k_str}"
targets[key] = [] unless targets.key? key
browser = nil
diff --git a/core/ruby/print.rb b/core/ruby/print.rb
index fbf932ac09..bab8b16763 100644
--- a/core/ruby/print.rb
+++ b/core/ruby/print.rb
@@ -7,14 +7,14 @@
# Function used to print errors to the console
# @param [String] s String to be printed
def print_error(s)
- puts Time.now.localtime.strftime('[%k:%M:%S]') + '[!]' + ' ' + s.to_s
+ puts "#{Time.now.localtime.strftime('[%k:%M:%S]')}[!] #{s}"
BeEF.logger.error s.to_s
end
# Function used to print information to the console
# @param [String] s String to be printed
def print_info(s)
- puts Time.now.localtime.strftime('[%k:%M:%S]') + '[*]' + ' ' + s.to_s
+ puts "#{Time.now.localtime.strftime('[%k:%M:%S]')}[*] #{s}"
BeEF.logger.info s.to_s
end
@@ -27,7 +27,7 @@ def print_status(s)
# Function used to print warning information
# @param [String] s String to be printed
def print_warning(s)
- puts Time.now.localtime.strftime('[%k:%M:%S]') + '[!]' + ' ' + s.to_s
+ puts "#{Time.now.localtime.strftime('[%k:%M:%S]')}[!] #{s}"
BeEF.logger.warn s.to_s
end
@@ -38,14 +38,14 @@ def print_debug(s)
config = BeEF::Core::Configuration.instance
return unless config.get('beef.debug') || BeEF::Core::Console::CommandLine.parse[:verbose]
- puts Time.now.localtime.strftime('[%k:%M:%S]') + '[>]' + ' ' + s.to_s
+ puts "#{Time.now.localtime.strftime('[%k:%M:%S]')}[>] #{s}"
BeEF.logger.debug s.to_s
end
# Function used to print successes to the console
# @param [String] s String to be printed
def print_success(s)
- puts Time.now.localtime.strftime('[%k:%M:%S]') + '[+]' + ' ' + s.to_s
+ puts "#{Time.now.localtime.strftime('[%k:%M:%S]')}[+] #{s}"
BeEF.logger.info s.to_s
end
diff --git a/extensions/admin_ui/api/handler.rb b/extensions/admin_ui/api/handler.rb
index c220af8ba0..c025bf24b1 100644
--- a/extensions/admin_ui/api/handler.rb
+++ b/extensions/admin_ui/api/handler.rb
@@ -46,7 +46,7 @@ def self.evaluate_and_minify(content, params)
print_debug "[AdminUI] Minified #{evaluated.size} bytes to #{minified.size} bytes"
- return minified
+ minified
end
def self.write_minified_js(name, content)
@@ -100,7 +100,7 @@ def self.build_javascript_ui
admin_ui_js = ''
global_js.each do |file_name|
- admin_ui_js << ("#{File.binread("#{File.dirname(__FILE__)}/../media/javascript/#{file_name}")}\n\n")
+ admin_ui_js << "#{File.binread("#{File.dirname(__FILE__)}/../media/javascript/#{file_name}")}\n\n"
end
config = BeEF::Core::Configuration.instance
@@ -117,15 +117,17 @@ def self.build_javascript_ui
web_ui_all = evaluate_and_minify(admin_ui_js, params)
unless web_ui_all
- raise StandardError, "[AdminUI] evaluate_and_minify JavaScript failed: web_ui_all JavaScript is empty"
+ raise StandardError, '[AdminUI] evaluate_and_minify JavaScript failed: web_ui_all JavaScript is empty'
end
+
write_minified_js('web_ui_all.js', web_ui_all)
auth_js_file = "#{File.binread("#{File.dirname(__FILE__)}/../media/javascript/ui/authentication.js")}\n\n"
web_ui_auth = evaluate_and_minify(auth_js_file, params)
unless web_ui_auth
- raise StandardError, "[AdminUI] evaluate_and_minify JavaScript failed: web_ui_auth JavaScript is empty"
+ raise StandardError, '[AdminUI] evaluate_and_minify JavaScript failed: web_ui_auth JavaScript is empty'
end
+
write_minified_js('web_ui_auth.js', web_ui_auth)
rescue => e
raise StandardError, "Building Admin UI JavaScript failed: #{e.message}"
diff --git a/extensions/admin_ui/classes/httpcontroller.rb b/extensions/admin_ui/classes/httpcontroller.rb
index 85bc91bc4f..8f1e3bdfd9 100644
--- a/extensions/admin_ui/classes/httpcontroller.rb
+++ b/extensions/admin_ui/classes/httpcontroller.rb
@@ -87,7 +87,7 @@ def run(request, response)
return
end
- function = @paths[path] || @paths[path + '/'] # check hash for '
' and '/'
+ function = @paths[path] || @paths["#{path}/"] # check hash for '' and '/'
if function.nil?
print_error "[Admin UI] Path does not exist: #{path}"
return
@@ -143,8 +143,6 @@ def base_path
private
- @eruby
-
# Unescapes a URL-encoded string.
def unescape(s)
s.tr('+', ' ').gsub(/%([\da-f]{2})/in) { [Regexp.last_match(1)].pack('H*') }
diff --git a/extensions/admin_ui/classes/session.rb b/extensions/admin_ui/classes/session.rb
index d54883313f..cd47fec10a 100644
--- a/extensions/admin_ui/classes/session.rb
+++ b/extensions/admin_ui/classes/session.rb
@@ -100,7 +100,6 @@ def valid_session?(request)
request.cookies.each do |cookie|
return true if (cookie[0].to_s.eql? session_cookie_name) and (cookie[1].eql? @id)
end
- request
# not a valid session
false
diff --git a/extensions/admin_ui/controllers/modules/modules.rb b/extensions/admin_ui/controllers/modules/modules.rb
index 36c863fe12..e11052461a 100644
--- a/extensions/admin_ui/controllers/modules/modules.rb
+++ b/extensions/admin_ui/controllers/modules/modules.rb
@@ -82,10 +82,9 @@ def set_command_module_status(mod)
# @param category [Array] The category to add the leaf to
# @param leaf [Hash] The leaf to add to the tree
def update_command_module_tree_recurse(tree, category, leaf)
-
# get a single folder from the category array
working_category = category.shift
-
+
tree.each do |t|
if t['text'].eql?(working_category) && category.count > 0
# We have deeper to go
@@ -190,14 +189,13 @@ def retitle_recursive_tree(parent)
retitle_recursive_tree([c]) if c.has_key?('cls') && c['cls'] == 'folder'
end
num_of_command_modules = command_module_branch['children'].length + num_of_subs
- command_module_branch['text'] = command_module_branch['text'] + ' (' + num_of_command_modules.to_s + ')'
+ command_module_branch['text'] = "#{command_module_branch['text']} (#{num_of_command_modules})"
end
end
# Returns the list of all command_modules for a TreePanel in the interface.
def select_command_modules_tree
blanktree = []
- tree = []
# Due to the sub-folder nesting, we use some really badly hacked together recursion
# Note to the bored - if someone (anyone please) wants to refactor, I'll buy you cookies. -x
@@ -242,7 +240,7 @@ def select_command_modules_tree
sort_recursive_tree(tree)
retitle_recursive_tree(tree)
-
+
# return a JSON array of hashes
@body = tree.to_json
end
@@ -254,7 +252,7 @@ def select_command_module
print_error 'command_module_id is nil'
return
end
- command_module = BeEF::Core::Models::CommandModule.find(command_module_id)
+ BeEF::Core::Models::CommandModule.find(command_module_id)
key = BeEF::Module.get_key_by_database_id(command_module_id)
payload_name = @params['payload_name'] || nil
@@ -307,11 +305,11 @@ def select_command_module_commands
C.where(command_module_id: command_module_id, hooked_browser_id: zombie_id).each do |command|
commands.push({
- 'id' => i,
- 'object_id' => command.id,
- 'creationdate' => Time.at(command.creationdate.to_i).strftime('%Y-%m-%d %H:%M').to_s,
- 'label' => command.label
- })
+ 'id' => i,
+ 'object_id' => command.id,
+ 'creationdate' => Time.at(command.creationdate.to_i).strftime('%Y-%m-%d %H:%M').to_s,
+ 'label' => command.label
+ })
i += 1
end
diff --git a/extensions/admin_ui/handlers/ui.rb b/extensions/admin_ui/handlers/ui.rb
index 208811a6cd..8dec343ae3 100644
--- a/extensions/admin_ui/handlers/ui.rb
+++ b/extensions/admin_ui/handlers/ui.rb
@@ -27,14 +27,11 @@ def call(env)
controller.run(@request, @response)
@response = Rack::Response.new(
- body = [controller.body],
- status = controller.status,
- header = controller.headers
+ [controller.body],
+ controller.status,
+ controller.headers
)
end
-
- @request
- @response
end
end
end
diff --git a/extensions/customhook/handler.rb b/extensions/customhook/handler.rb
index 7803da54bc..fa1638234f 100644
--- a/extensions/customhook/handler.rb
+++ b/extensions/customhook/handler.rb
@@ -9,14 +9,16 @@ module Customhook
class Handler
def call(env)
@body = ''
+ # @note Object representing the HTTP request
@request = Rack::Request.new(env)
@params = @request.query_string
- @response = Rack::Response.new(body = [], 200, header = {})
+ # @note Object representing the HTTP response
+ @response = Rack::Response.new([], 200, {})
config = BeEF::Core::Configuration.instance
eruby = Erubis::FastEruby.new(File.read("#{File.dirname(__FILE__)}/html/index.html"))
config.get('beef.extension.customhook.hooks').each do |h|
path = config.get("beef.extension.customhook.hooks.#{h.first}.path")
- next unless path == (env['REQUEST_URI']).to_s
+ next unless path == env['REQUEST_URI'].to_s
print_info "[Custom Hook] Handling request for custom hook mounted at '#{path}'"
@body << eruby.evaluate({
@@ -27,9 +29,9 @@ def call(env)
end
@response = Rack::Response.new(
- body = [@body],
- status = 200,
- header = {
+ [@body],
+ 200,
+ {
'Pragma' => 'no-cache',
'Cache-Control' => 'no-cache',
'Expires' => '0',
@@ -39,12 +41,6 @@ def call(env)
}
)
end
-
- # @note Object representing the HTTP request
- @request
-
- # @note Object representing the HTTP response
- @response
end
end
end
diff --git a/extensions/demos/handler.rb b/extensions/demos/handler.rb
index d52eb18fec..41fae2df8e 100644
--- a/extensions/demos/handler.rb
+++ b/extensions/demos/handler.rb
@@ -7,7 +7,7 @@ module BeEF
module Extension
module Demos
class Handler < BeEF::Core::Router::Router
- set :public_folder, File.expand_path(File.dirname(__FILE__)) + '/html/'
+ set :public_folder, "#{__dir__}/html/"
end
end
end
diff --git a/extensions/dns/api.rb b/extensions/dns/api.rb
index f4e14551c2..936edd1d08 100644
--- a/extensions/dns/api.rb
+++ b/extensions/dns/api.rb
@@ -24,7 +24,7 @@ module NameserverHandler
#
# @param http_hook_server [BeEF::Core::Server] HTTP server instance
def self.pre_http_start(_http_hook_server)
- servers, interfaces, address, port, protocol, upstream_servers = get_dns_config # get the DNS configuration
+ servers, interfaces, = get_dns_config # get the DNS configuration
# Start the DNS server
dns = BeEF::Extension::Dns::Server.instance
@@ -32,7 +32,7 @@ def self.pre_http_start(_http_hook_server)
end
def self.print_dns_info
- servers, interfaces, address, port, protocol, upstream_servers = get_dns_config # get the DNS configuration
+ _, _, address, port, protocol, upstream_servers = get_dns_config # get the DNS configuration
# Print the DNS server information
print_info "DNS Server: #{address}:#{port} (#{protocol})"
@@ -67,7 +67,7 @@ def self.get_dns_config
end
end
- return servers, interfaces, address, port, protocol, upstream_servers
+ [servers, interfaces, address, port, protocol, upstream_servers]
end
# Mounts the handler for processing DNS RESTful API requests.
diff --git a/extensions/dns/dns.rb b/extensions/dns/dns.rb
index ccddb45130..b530f36ab8 100644
--- a/extensions/dns/dns.rb
+++ b/extensions/dns/dns.rb
@@ -14,7 +14,7 @@ class Server < Async::DNS::Server
include Singleton
def initialize
- super()
+ super
logger.level = Logger::ERROR
@lock = Mutex.new
@database = BeEF::Core::Models::Dns::Rule
@@ -121,6 +121,7 @@ def run(options = {})
Thread.new do
EventMachine.next_tick do
next if @server_started # Check if the server was already started
+
upstream = options[:upstream] || nil
listen = options[:listen] || nil
@@ -152,7 +153,7 @@ def run(options = {})
def stop
return unless @server_started # Check if the server was started
-
+
# Logic to stop the Async::DNS server
puts EventMachine.stop if EventMachine.reactor_running?
@server_started = false # Reset the server started flag
diff --git a/extensions/dns/model.rb b/extensions/dns/model.rb
index 04633aa871..1bca9c5452 100644
--- a/extensions/dns/model.rb
+++ b/extensions/dns/model.rb
@@ -149,13 +149,7 @@ def format_callback(resource, response)
minimum: response[6]
}
- format "t.respond!(Resolv::DNS::Name.create('%s'), " +
- "Resolv::DNS::Name.create('%s'), " +
- '%d, ' +
- '%d, ' +
- '%d, ' +
- '%d, ' +
- '%d)',
+ format "t.respond!(Resolv::DNS::Name.create('%s'), Resolv::DNS::Name.create('%s'), %d, %d, %d, %d, %d)",
data
elsif (response.is_a?(Symbol) && response.to_s =~ sym_regex) || response =~ sym_regex
format 't.fail!(:%s)', response.to_sym
@@ -201,7 +195,7 @@ class InvalidDnsResponseError < StandardError
def initialize(message = nil)
str = 'Failed to add DNS rule with invalid response for %s resource record', message
message = format str, message unless message.nil?
- super(message)
+ super
end
end
diff --git a/extensions/dns/rest/dns.rb b/extensions/dns/rest/dns.rb
index ac3f2a8313..bf5997a124 100644
--- a/extensions/dns/rest/dns.rb
+++ b/extensions/dns/rest/dns.rb
@@ -151,7 +151,7 @@ class InvalidParamError < StandardError
def initialize(message = nil)
str = 'Invalid "%s" parameter passed to /api/dns handler'
message = format str, message unless message.nil?
- super(message)
+ super
end
end
end
diff --git a/extensions/dns_rebinding/dns_rebinding.rb b/extensions/dns_rebinding/dns_rebinding.rb
index ed6cf8cc1e..bf42c681f6 100644
--- a/extensions/dns_rebinding/dns_rebinding.rb
+++ b/extensions/dns_rebinding/dns_rebinding.rb
@@ -5,7 +5,7 @@ module DNSRebinding
class Server
@debug_mode = false
def self.log(msg)
- warn msg.to_s if @debug_mode
+ warn msg if @debug_mode
end
def self.run_server(address, port)
@@ -17,7 +17,7 @@ def self.run_server(address, port)
victim_ip = socket.peeraddr[2].to_s
log "-------------------------------\n"
- log '[Server] Incoming request from ' + victim_ip + "(Victim)\n"
+ log "[Server] Incoming request from #{victim_ip}(Victim)\n"
response = File.read(File.expand_path('views/index.html', __dir__))
configuration = BeEF::Core::Configuration.instance
@@ -29,10 +29,7 @@ def self.run_server(address, port)
response.sub!('path_to_hookjs_template', hook_uri)
start_string = socket.gets
- socket.print "HTTP/1.1 200 OK\r\n" +
- "Content-Type: text/html\r\n" +
- "Content-Length: #{response.bytesize}\r\n" +
- "Connection: close\r\n"
+ socket.print "HTTP/1.1 200 OK\r\nContent-Type: text/html\r\nContent-Length: #{response.bytesize}\r\nConnection: close\r\n"
socket.print "\r\n"
socket.print response
socket.close
@@ -81,7 +78,7 @@ def self.send_http_response(socket, response, heads = {})
end
headers.to_a.each do |header, value|
- socket.print header + ': ' + value + "\r\n"
+ socket.print "#{header}: #{value}\r\n"
end
socket.print "\r\n"
@@ -115,7 +112,7 @@ def self.read_http_message(socket)
def self.handle_victim(socket, http_message)
log "[Victim]request from victim\n"
- log http_message['start_string'].to_s + "\n"
+ log "#{http_message['start_string']}\n"
if http_message['start_string'].include?('POST')
# Get result from POST query
@@ -123,12 +120,12 @@ def self.handle_victim(socket, http_message)
# Read query on which asked victim
query = http_message['start_string'][/path=([^HTP]+)/, 1][0..-2]
- log '[Victim]asked path: ' + query + "\n"
+ log "[Victim]asked path: #{query}\n"
length = http_message['headers']['Content-Length'].to_i
content_type = http_message['headers']['Content-Type']
- log '[Victim]Content-type: ' + content_type.to_s + "\n"
- log '[Vicitm]Length: ' + length.to_s + "\n"
+ log "[Victim]Content-type: #{content_type}\n"
+ log "[Vicitm]Length: #{length}\n"
response = http_message['response']
log "[Victim]Get content!\n"
@@ -157,7 +154,7 @@ def self.handle_victim(socket, http_message)
@mutex_queries.lock
log "[Victim]Get the last query\n"
last_query = @queries.pop
- log '[Victim]Last query:' + last_query.to_s + "\n"
+ log "[Victim]Last query:#{last_query}\n"
@mutex_queries.unlock
response = last_query[2]
@@ -175,7 +172,7 @@ def self.handle_owner(socket, http_message)
if http_message['start_string'].include?('GET')
unless path.nil?
- log '[Owner]Need path: ' + path + "\n"
+ log "[Owner]Need path: #{path}\n"
@queries.push(['GET', path, ''])
end
elsif http_message['start_string'].include?('POST')
diff --git a/extensions/etag/etag.rb b/extensions/etag/etag.rb
index 51425af55b..8bb1779045 100644
--- a/extensions/etag/etag.rb
+++ b/extensions/etag/etag.rb
@@ -11,6 +11,7 @@ module ETag
class ETagMessages
include Singleton
+
attr_accessor :messages
def initialize
diff --git a/extensions/evasion/obfuscation/scramble.rb b/extensions/evasion/obfuscation/scramble.rb
index 1ebfc0ee08..1d0f215613 100644
--- a/extensions/evasion/obfuscation/scramble.rb
+++ b/extensions/evasion/obfuscation/scramble.rb
@@ -29,7 +29,6 @@ def execute(input, config)
@output.gsub!(var, value)
print_debug "[OBFUSCATION - SCRAMBLER] string [#{var}] scrambled -> [#{value}]"
end
- @output
end
if config.get('beef.extension.evasion.scramble_cookies')
@@ -44,8 +43,6 @@ def execute(input, config)
print_debug "[OBFUSCATION - SCRAMBLER] cookie [BEEFHOOK] scrambled -> [#{config.get('beef.http.hook_session_name')}]"
end
end
-
- @output
end
end
end
diff --git a/extensions/metasploit/rest/msf.rb b/extensions/metasploit/rest/msf.rb
index e848e4a713..0cd24f860e 100644
--- a/extensions/metasploit/rest/msf.rb
+++ b/extensions/metasploit/rest/msf.rb
@@ -127,7 +127,7 @@ class InvalidParamError < StandardError
def initialize(message = nil)
str = 'Invalid "%s" parameter passed to /api/msf handler'
message = format str, message unless message.nil?
- super(message)
+ super
end
end
end
diff --git a/extensions/metasploit/rpcclient.rb b/extensions/metasploit/rpcclient.rb
index a7502c0f90..0cd9a74f33 100644
--- a/extensions/metasploit/rpcclient.rb
+++ b/extensions/metasploit/rpcclient.rb
@@ -119,7 +119,7 @@ def release_lock
end
def call(meth, *args)
- super(meth, *args)
+ super
rescue StandardError => e
print_error "[Metasploit] RPC call to '#{meth}' failed: #{e}"
print_error e.backtrace
diff --git a/extensions/network/rest/network.rb b/extensions/network/rest/network.rb
index f5a9563b23..a7a5a53959 100644
--- a/extensions/network/rest/network.rb
+++ b/extensions/network/rest/network.rb
@@ -178,7 +178,7 @@ class InvalidParamError < StandardError
def initialize(message = nil)
message = "Invalid \"#{message}\" parameter passed to /api/network handler" unless message.nil?
- super(message)
+ super
end
end
end
diff --git a/extensions/notifications/channels/ntfy.rb b/extensions/notifications/channels/ntfy.rb
index 343d503cdc..ad4895f1ed 100644
--- a/extensions/notifications/channels/ntfy.rb
+++ b/extensions/notifications/channels/ntfy.rb
@@ -6,7 +6,6 @@ module Extension
module Notifications
module Channels
class Ntfy
-
# Constructor
def initialize(message)
@config = BeEF::Core::Configuration.instance
@@ -36,7 +35,6 @@ def initialize(message)
# Send request
http.request(req)
end
-
end
end
end
diff --git a/extensions/notifications/notifications.rb b/extensions/notifications/notifications.rb
index b42179b406..ca38d76eb9 100644
--- a/extensions/notifications/notifications.rb
+++ b/extensions/notifications/notifications.rb
@@ -9,7 +9,6 @@
require 'extensions/notifications/channels/slack_workspace'
require 'extensions/notifications/channels/ntfy'
-
module BeEF
module Extension
module Notifications
@@ -38,7 +37,6 @@ def initialize(from, event, time_now, hb)
BeEF::Extension::Notifications::Channels::SlackWorkspace.new(message) if @config.get('beef.extension.notifications.slack.enable') == true
BeEF::Extension::Notifications::Channels::Ntfy.new(message) if @config.get('beef.extension.notifications.ntfy.enable') == true
-
end
end
end
diff --git a/extensions/proxy/api.rb b/extensions/proxy/api.rb
index 21bdbbaa60..ddc1c1c60c 100644
--- a/extensions/proxy/api.rb
+++ b/extensions/proxy/api.rb
@@ -12,7 +12,7 @@ module RegisterHttpHandler
BeEF::API::Registrar.instance.register(BeEF::Extension::Proxy::API::RegisterHttpHandler, BeEF::API::Server, 'mount_handler')
def self.pre_http_start(http_hook_server)
- config = BeEF::Core::Configuration.instance
+ BeEF::Core::Configuration.instance
Thread.new do
http_hook_server.semaphore.synchronize do
BeEF::Extension::Proxy::Proxy.new
diff --git a/extensions/proxy/rest/proxy.rb b/extensions/proxy/rest/proxy.rb
index 3753103dfe..952f335e89 100644
--- a/extensions/proxy/rest/proxy.rb
+++ b/extensions/proxy/rest/proxy.rb
@@ -73,7 +73,7 @@ class InvalidParamError < StandardError
def initialize(message = nil)
str = 'Invalid "%s" parameter passed to /api/proxy handler'
message = format str, message unless message.nil?
- super(message)
+ super
end
end
end
diff --git a/extensions/qrcode/qrcode.rb b/extensions/qrcode/qrcode.rb
index 6f4df29019..a56c0889e4 100644
--- a/extensions/qrcode/qrcode.rb
+++ b/extensions/qrcode/qrcode.rb
@@ -28,15 +28,16 @@ def self.pre_http_start(_http_hook_server)
fullurls << target
# relative URLs
else
-
+
# Retrieve the list of network interfaces from BeEF::Core::Console::Banners
interfaces = BeEF::Core::Console::Banners.interfaces
- if not interfaces.nil? and not interfaces.empty? # If interfaces are available, iterate over each network interface
+ if !interfaces.nil? and !interfaces.empty? # If interfaces are available, iterate over each network interface
# If interfaces are available, iterate over each network interface
interfaces.each do |int|
# Skip the loop iteration if the interface address is '0.0.0.0' (which generally represents all IPv4 addresses on the local machine)
next if int == '0.0.0.0'
+
# Construct full URLs using the network interface address, and add them to the fullurls array
# The URL is composed of the BeEF protocol, interface address, BeEF port, and the target path
fullurls << "#{beef_proto}://#{int}:#{beef_port}#{target}"
diff --git a/extensions/requester/api/hook.rb b/extensions/requester/api/hook.rb
index 6c3f729900..81b75b3f01 100644
--- a/extensions/requester/api/hook.rb
+++ b/extensions/requester/api/hook.rb
@@ -106,13 +106,13 @@ def requester_parse_db_request(http_db_object)
req_parts.each_with_index do |value, index|
if verb.eql?('POST')
if index.positive? && (index < @post_data_index) # only add HTTP headers, not the verb/uri/version or post-data
- header_key = value.split(/: /)[0]
- header_value = value.split(/: /)[1]
+ header_key = value.split(': ')[0]
+ header_value = value.split(': ')[1]
headers[header_key] = header_value
end
elsif index.positive?
- header_key = value.split(/: /)[0]
- header_value = value.split(/: /)[1]
+ header_key = value.split(': ')[0]
+ header_value = value.split(': ')[1]
headers[header_key] = header_value # only add HTTP headers, not the verb/uri/version
end
end
diff --git a/extensions/requester/rest/requester.rb b/extensions/requester/rest/requester.rb
index 76585bddb1..112fe023bf 100644
--- a/extensions/requester/rest/requester.rb
+++ b/extensions/requester/rest/requester.rb
@@ -160,7 +160,7 @@ class RequesterRest < BeEF::Core::Router::Router
# Validate target hsot
host = req_parts[4]
- host_parts = host.split(/:/)
+ host_parts = host.split(':')
host_name = host_parts[0]
host_port = host_parts[1] || nil
@@ -230,7 +230,7 @@ def response2hash(http)
response_data = ''
unless http.response_data.nil?
- if (http.response_data.length > (1024 * 100)) # more than 100K
+ if http.response_data.length > (1024 * 100) # more than 100K
response_data = http.response_data[0..(1024 * 100)]
response_data += "\n<---------- Response Data Truncated---------->"
else
@@ -271,7 +271,7 @@ class InvalidParamError < StandardError
def initialize(message = nil)
str = 'Invalid "%s" parameter passed to /api/requester handler'
message = format str, message unless message.nil?
- super(message)
+ super
end
end
end
diff --git a/extensions/s2c_dns_tunnel/dnsd.rb b/extensions/s2c_dns_tunnel/dnsd.rb
index aa9ef8f701..0094b22a9f 100644
--- a/extensions/s2c_dns_tunnel/dnsd.rb
+++ b/extensions/s2c_dns_tunnel/dnsd.rb
@@ -34,7 +34,7 @@ class Server < RubyDNS::Server
attr_accessor :messages
def initialize
- super()
+ super
@lock = Mutex.new
end
diff --git a/extensions/s2c_dns_tunnel/extension.rb b/extensions/s2c_dns_tunnel/extension.rb
index 491963bfe1..3100675754 100644
--- a/extensions/s2c_dns_tunnel/extension.rb
+++ b/extensions/s2c_dns_tunnel/extension.rb
@@ -7,6 +7,7 @@ module BeEF
module Extension
module ServerClientDnsTunnel
extend BeEF::API::Extension
+
@short_name = 'S2C DNS Tunnel'
@full_name = 'Server-to-Client DNS Tunnel'
@description = 'This extension provides a custom BeEF DNS server and HTTP server ' \
diff --git a/extensions/s2c_dns_tunnel/httpd.rb b/extensions/s2c_dns_tunnel/httpd.rb
index ef775e6cc4..add8c4c958 100644
--- a/extensions/s2c_dns_tunnel/httpd.rb
+++ b/extensions/s2c_dns_tunnel/httpd.rb
@@ -8,7 +8,7 @@ def initialize(domain)
end
get '/map' do
- if request.host.match("^_ldap\._tcp\.[0-9a-z\-]+\.domains\._msdcs\.#{@domain}$")
+ if request.host.match("^_ldap._tcp.[0-9a-z-]+.domains._msdcs.#{@domain}$")
path = File.dirname(__FILE__)
send_file File.join(path, 'pixel.jpg')
end
diff --git a/extensions/social_engineering/rest/socialengineering.rb b/extensions/social_engineering/rest/socialengineering.rb
index fad2145009..58a4d53bcf 100644
--- a/extensions/social_engineering/rest/socialengineering.rb
+++ b/extensions/social_engineering/rest/socialengineering.rb
@@ -52,12 +52,12 @@ class SEngRest < BeEF::Core::Router::Router
success = web_cloner.clone_page(uri, mount, use_existing, dns_spoof)
if success
- result = {
+ {
'success' => true,
'mount' => mount
}.to_json
else
- result = {
+ {
'success' => false
}.to_json
halt 500
diff --git a/extensions/social_engineering/web_cloner/web_cloner.rb b/extensions/social_engineering/web_cloner/web_cloner.rb
index 67fab749d4..200471cf75 100644
--- a/extensions/social_engineering/web_cloner/web_cloner.rb
+++ b/extensions/social_engineering/web_cloner/web_cloner.rb
@@ -55,7 +55,6 @@ def clone_page(url, mount, use_existing, dns_spoof)
if line.include?('![\"[](\"#{bp}/media/images/icons/apache_pb.gif\"){kind=icon}
![\"[](\"#{bp}/media/images/icons/powered_by_rh.png\"){kind=icon}