Why is French DualFromZeroToTwo instead of DualOneOther?

[Fuitad]

Heya,

I'm trying to understand why French is set to DualFromZeroToTwo instead of DualOneOther like English. I'm French Canadian and I'm having a hard time understanding why

{0:plural:No object|{} object|{} objects} cached on file system is working in English but {0:plural:Aucun objet|{} objet|{} objets} en cache sur le système in French is giving me SmartFormat.Core.Formatting.FormattingException: Error parsing format string: Invalid number of plural parameters in PluralLocalizationFormatter

Maybe there's something in FR-FR that explains this? But on a French Canadian point of view, this doesn't make much sense.

[axunonb]

My French is not good enough to argue about plural rules.
We're referring to the rules published on unicode.org. Here you can see that English and French plural rules are in fact different. The question is, of course, whether the colloquial language adheres to the rules.

[Fuitad]

Ok I get it now. It's because the formatting can change once you get past 1 million. Sorry for the trouble!

[Fuitad]

I'm really sorry to bug you again. I've changed {0:plural:Aucun objet|{} objet|{} objets} to {0:plural:Aucun objet|{} objet|{} objets|{} objets} but I'm still getting the same invalid number of plural parameters error. Just how many parameters am I supposed to provide in French?

[axunonb]

Example:

//  new string[3] is just get array with 3 items
var result = Smart.Format(CultureInfo.GetCultureInfo("fr"), "{0:plural:une personne|deux personnes|plusieurs personnes}", new string[3]);```
// result: , "plusieurs personnes"

[Fuitad]

But in that example, what happens for zero?

[axunonb]

The plural word options matter. Have a look at the DualFromZeroToTwo delegate:
https://github.com/axuno/SmartFormat/blob/a9b0fb356274cd78ece239613a1f163e4d5b88ca/src/SmartFormat/Utilities/PluralRules.cs#L215C1-L245C6

For only 2 options we have:

var result = smart.Format(CultureInfo.GetCultureInfo("fr"), "{0:plural:{} personne|plusieurs personne}", 0);
// 0 personne
result = smart.Format(CultureInfo.GetCultureInfo("fr"), "{0:plural:{} personne|{} personnes}", 1);
// 1 personne
result = smart.Format(CultureInfo.GetCultureInfo("fr"), "{0:plural:{} personne|{} personnes}", 2);
// 2 personnes
result = smart.Format(CultureInfo.GetCultureInfo("fr"), "{0:plural:{} personne|{} personnes}", 3);
// 3 personnes
result = smart.Format(CultureInfo.GetCultureInfo("fr"), "{0:plural:{} personne|{} personnes}", 100);
// 100 personnes

[axunonb]

@karljj1 Please have glance at https://github.com/axuno/SmartFormat/blob/a9b0fb356274cd78ece239613a1f163e4d5b88ca/src/SmartFormat/Utilities/PluralRules.cs#L215C1-L245C6
If n == 2 we get a failure. The switch case should read >= 2 instead of > 2, shouldn't it?
Cannot believe that nobody had noticed this before...

[karljj1]

Hey. Sorry I have been on holiday for the last 2 weeks. I'll take a look after the holidays 😃

[axunonb]

Best season's greetings 🍀

[karljj1]

Looks like we are using the older version DualFromZeroToTwo => (n, c) => n == 0 || n == 1 ? 0 : 1;, we have made no changes. I guess no one has encountered this issue yet. value < 2 ? 0 : 1; looks correct to me, am I missing something?
French only has One and Other right?

[axunonb]

French only has One and Other right?
Yes, I think so. Zero and one is singular, other are plural. @Fuitad Right?

The point is, that a value of 2 should be plural, but exactly 2 is not covered with the rule at all and returns an error result of -1. That doesn't make sense to me, but this has never been opened as an issue.
https://github.com/axuno/SmartFormat/blob/a9b0fb356274cd78ece239613a1f163e4d5b88ca/src/SmartFormat/Utilities/PluralRules.cs#L215C1-L245C6

[karljj1]

I see. I guess no one has ever needed 2 items in French! Your suggested change makes sense.

[Fuitad]

French only has One and Other right?
Yes, I think so. Zero and one is singular, other are plural. @Fuitad Right?

This is correct. Aucune porte (no door), une porte (one door), deux portes (two doors)