Fix Use button not updating SparseTree row display

- Client: onFieldChanged now refetches person data after applying override
- Server: getPerson() now applies local overrides to returned person data
- Added applyLocalOverridesToPerson() to database.service.ts

Author: atomantic

.changelog/v0.6.x.md

@@ -67,6 +67,14 @@ This release normalizes FamilySearch as a downstream provider (equal to Ancestry
 - Added detailed debug logging for photo extraction troubleshooting
 - Improved UI feedback: loading toast during scrape, success toast shows extracted fields
 
+### "Use" Button Not Updating SparseTree Row (v0.6.x)
+- Fixed clicking "Use" on provider field values not updating the SparseTree row display
+- Root causes fixed:
+  - Client: `onFieldChanged` callback now refetches person data after applying override
+  - Server: `getPerson()` now applies local overrides to returned person data
+- Added `applyLocalOverridesToPerson()` to database service for consistent override application
+- Birth/death date/place values from providers now properly display after clicking "Use"
+
 ### "Set as Primary" Photo Not Updating (v0.6.x)
 - Fixed photo not updating after clicking "Set as Primary" on provider photos
 - Root causes fixed:

client/src/components/person/PersonDetail.tsx

@@ -190,6 +190,7 @@ export function PersonDetail() {
   const [showUploadDialog, setShowUploadDialog] = useState(false);
   const [showAncestryUploadDialog, setShowAncestryUploadDialog] = useState(false);
   const [showRelationshipModal, setShowRelationshipModal] = useState(false);
+  const [hintsProcessing, setHintsProcessing] = useState(false);
 
   // Local overrides state
   const [overrides, setOverrides] = useState<PersonOverrides | null>(null);
@@ -495,6 +496,36 @@ export function PersonDetail() {
     setSyncLoading(false);
   };
 
+  const handleProcessAncestryHints = async () => {
+    if (!dbId || !personId) return;
+
+    setHintsProcessing(true);
+
+    const result = await api.processAncestryHints(dbId, personId).catch(err => {
+      toast.error(`Failed to process hints: ${err.message}`);
+      return null;
+    });
+
+    if (result) {
+      if (result.hintsProcessed > 0) {
+        toast.success(`Processed ${result.hintsProcessed} free hints on Ancestry`);
+        // Refresh data from Ancestry after processing hints
+        await handleRefreshProvider('ancestry');
+      } else if (result.hintsFound === 0) {
+        toast('No free hints available', { icon: 'ℹ️' });
+      } else if (result.errors.length > 0) {
+        toast.error(`Hints processing failed: ${result.errors[0]}`);
+      }
+    }
+
+    setHintsProcessing(false);
+  };
+
+  const handleRefreshProvider = async (provider: 'ancestry' | 'wikitree' | 'familysearch') => {
+    if (!dbId || !personId) return;
+    await api.refreshFromProvider(dbId, personId, provider).catch(() => null);
+  };
+
   // =============================================================================
   // LOCAL OVERRIDE HANDLERS
   // =============================================================================
@@ -596,6 +627,15 @@ export function PersonDetail() {
     toast.success('Deleted');
   }, [dbId, personId, refreshOverrides]);
 
+  // Called when a field value is applied from provider data (e.g., "Use" button)
+  const handleFieldApplied = useCallback(async () => {
+    await refreshOverrides();
+    // Refresh person data to show the new value in the SparseTree row
+    if (!dbId || !personId) return;
+    const newPerson = await api.getPerson(dbId, personId);
+    if (newPerson) setPerson(newPerson);
+  }, [dbId, personId, refreshOverrides]);
+
   // =============================================================================
   // HELPER FUNCTIONS FOR OVERRIDES
   // =============================================================================
@@ -1159,10 +1199,12 @@ export function PersonDetail() {
             onShowAncestryUploadDialog={() => setShowAncestryUploadDialog(true)}
             onShowLinkInput={(platform) => setLinkingPlatform(platform)}
             onPhotoChanged={refreshPhotoState}
-            onFieldChanged={refreshOverrides}
+            onFieldChanged={handleFieldApplied}
+            onProcessAncestryHints={handleProcessAncestryHints}
             syncLoading={syncLoading}
             scrapeLoading={scrapeLoading}
             fetchingPhotoFrom={fetchingPhotoFrom}
+            hintsProcessing={hintsProcessing}
           />
 
           {/* Lineage path - compact */}
@@ -1198,6 +1240,11 @@ export function PersonDetail() {
           dbId={dbId}
           personId={personId}
           onClose={() => setShowUploadDialog(false)}
+          onPhotoSynced={() => {
+            // Photo was uploaded and synced to local cache - update UI without re-downloading
+            setHasFsPhoto(true);
+            setPhotoVersion(Date.now()); // Bust browser cache to show the photo
+          }}
         />
       )}
 

server/src/services/database.service.ts

@@ -4,6 +4,7 @@ import type { Database, DatabaseInfo, Person, PersonWithId } from '@fsf/shared';
 import { sqliteService } from '../db/sqlite.service.js';
 import { idMappingService } from './id-mapping.service.js';
 import { scraperService } from './scraper.service.js';
+import { localOverrideService } from './local-override.service.js';
 
 // Data directory is at root of project, not in server/
 const DATA_DIR = path.resolve(import.meta.dirname, '../../../data');
@@ -147,6 +148,59 @@ function findDatabasePath(id: string): string | null {
   return null;
 }
 
+/**
+ * Apply local overrides to a Person object
+ * Modifies the person in place to reflect user overrides
+ */
+function applyLocalOverridesToPerson(person: Person, personId: string): void {
+  // Get person-level overrides (name, gender)
+  const personOverrides = localOverrideService.getOverridesForEntity('person', personId);
+  for (const override of personOverrides) {
+    if (override.fieldName === 'name' && override.overrideValue) {
+      person.name = override.overrideValue;
+    } else if (override.fieldName === 'gender' && override.overrideValue) {
+      person.gender = override.overrideValue as 'male' | 'female' | 'unknown';
+    }
+  }
+
+  // Get vital event IDs for this person and check for overrides
+  const vitalEventIds = sqliteService.queryAll<{ id: number; event_type: string }>(
+    `SELECT id, event_type FROM vital_event WHERE person_id = @personId`,
+    { personId }
+  );
+
+  for (const event of vitalEventIds) {
+    const eventOverrides = localOverrideService.getOverridesForEntity('vital_event', String(event.id));
+    for (const override of eventOverrides) {
+      if (event.event_type === 'birth') {
+        if (!person.birth) person.birth = {};
+        if (override.fieldName === 'date' && override.overrideValue) {
+          person.birth.date = override.overrideValue;
+        } else if (override.fieldName === 'place' && override.overrideValue) {
+          person.birth.place = override.overrideValue;
+        }
+      } else if (event.event_type === 'death') {
+        if (!person.death) person.death = {};
+        if (override.fieldName === 'date' && override.overrideValue) {
+          person.death.date = override.overrideValue;
+        } else if (override.fieldName === 'place' && override.overrideValue) {
+          person.death.place = override.overrideValue;
+        }
+      }
+    }
+  }
+
+  // Also update the computed fields
+  if (person.birth?.date || person.death?.date) {
+    const birthYear = person.birth?.date?.match(/\d{4}/)?.at(0) ?? '';
+    const deathYear = person.death?.date?.match(/\d{4}/)?.at(0) ?? '';
+    person.lifespan = birthYear || deathYear ? `${birthYear}-${deathYear}` : '';
+  }
+  if (person.birth?.place || person.death?.place) {
+    person.location = person.birth?.place ?? person.death?.place ?? undefined;
+  }
+}
+
 // Build a Person object from SQLite data
 function buildPersonFromSqlite(
   personId: string,
@@ -278,6 +332,9 @@ function buildPersonFromSqlite(
     person.canonicalId = row.person_id;
   }
 
+  // Apply local overrides (user-set values take precedence)
+  applyLocalOverridesToPerson(person, personId);
+
   return person;
 }