Skip to content

Commit 203447d

Browse files
address co-pilot review #3930 (review)
1 parent a99b6ad commit 203447d

2 files changed

Lines changed: 10 additions & 6 deletions

File tree

‎lib/netstd/Thrift/Transport/Client/THttpPerCallTransport.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,13 @@ public override async Task FlushAsync(
7272

7373
_request.Position = 0;
7474
_response = await _parent.SendAsync(_request,cancellationToken);
75-
_sent = true;
7675

7776
#if NET5_0_OR_GREATER
7877
_responseStream = await _response.Content.ReadAsStreamAsync(cancellationToken);
7978
#else
8079
_responseStream = await _response.Content.ReadAsStreamAsync();
8180
#endif
81+
_sent = true;
8282
}
8383

8484
public override async ValueTask<int> ReadAsync(

‎lib/netstd/Thrift/Transport/Client/THttpTransport.cs‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,15 @@ public override async Task FlushAsync(CancellationToken cancellationToken)
245245
{
246246
contentStream.Headers.ContentType = ContentType ?? new MediaTypeHeaderValue(@"application/x-thrift");
247247

248-
var response = (await _httpClient.PostAsync(_uri, contentStream, cancellationToken)).EnsureSuccessStatusCode();
248+
using var request = new HttpRequestMessage(HttpMethod.Post, _uri)
249+
{
250+
Content = contentStream
251+
};
252+
253+
var response = (await _httpClient.SendAsync(
254+
request,
255+
HttpCompletionOption.ResponseHeadersRead,
256+
cancellationToken)).EnsureSuccessStatusCode();
249257

250258
_inputStream?.Dispose();
251259
#if NET5_0_OR_GREATER
@@ -366,10 +374,6 @@ internal async Task<HttpResponseMessage> SendAsync(Stream request, CancellationT
366374
response?.Dispose();
367375
throw new TTransportException(TTransportException.ExceptionType.Unknown, ex.Message, ex);
368376
}
369-
finally
370-
{
371-
ResetMessageSizeAndConsumedBytes();
372-
}
373377
}
374378
}
375379
}

0 commit comments

Comments
 (0)