comments

Author: xanderbailey

pyiceberg/encryption/kms.py

@@ -37,8 +37,8 @@ class KeyManagementClient(ABC):
 
     Wraps and unwraps table encryption keys using master keys that the service holds.
 
-    Implementations are loaded by name from the catalog properties, so a subclass must keep
-    this constructor signature, as `FileIO` does.
+    Subclasses must accept `properties` as their only required constructor argument, so that
+    they can be loaded by name like `FileIO`.
     """
 
     properties: Properties

tests/encryption/test_kms.py

@@ -38,6 +38,11 @@ def test_key_management_client_cannot_be_instantiated() -> None:
         KeyManagementClient()  # type: ignore[abstract]
 
 
+def test_client_keeps_its_properties() -> None:
+    assert MemoryKeyManagementClient().properties == {}
+    assert MemoryKeyManagementClient({"kms.key": "value"}).properties == {"kms.key": "value"}
+
+
 def test_generated_key_repr_redacts_key() -> None:
     generated = GeneratedKey(key=DEK, wrapped_key=b"wrapped")