From 1ef0cf119d7ba84d78836fa58cf521e9d3375c3f Mon Sep 17 00:00:00 2001 From: Sanjay Saravanan <75960494+sanjayms01@users.noreply.github.com> Date: Mon, 27 Apr 2026 22:35:07 -0700 Subject: [PATCH 1/7] MWPW-191927 Implementing Config-Based A/B Testing (#756) --- test/utils/experiment-provider.test.js | 2 +- .../workflow-acrobat/action-binder.js | 56 +++++++++++++------ unitylibs/scripts/utils.js | 13 +++++ unitylibs/utils/experiment-provider.js | 14 ++--- 4 files changed, 59 insertions(+), 26 deletions(-) diff --git a/test/utils/experiment-provider.test.js b/test/utils/experiment-provider.test.js index 3a397cacd..25f1378f2 100644 --- a/test/utils/experiment-provider.test.js +++ b/test/utils/experiment-provider.test.js @@ -1,6 +1,6 @@ /* eslint-disable no-underscore-dangle */ import { expect } from '@esm-bundle/chai'; -import { getExperimentData, getDecisionScopesForVerb } from '../../unitylibs/utils/experiment-provider.js'; +import getExperimentData, { getDecisionScopesForVerb } from '../../unitylibs/utils/experiment-provider.js'; describe('getExperimentData', () => { // Helper function to setup mock with result and error diff --git a/unitylibs/core/workflow/workflow-acrobat/action-binder.js b/unitylibs/core/workflow/workflow-acrobat/action-binder.js index e679a60a4..e4343970b 100644 --- a/unitylibs/core/workflow/workflow-acrobat/action-binder.js +++ b/unitylibs/core/workflow/workflow-acrobat/action-binder.js @@ -162,7 +162,7 @@ export default class ActionBinder { this.actionMap = actionMap; this.limits = {}; this.operations = []; - this.acrobatApiConfig = this.getAcrobatApiConfig(); + this.acrobatApiConfig = null; this.networkUtils = new NetworkUtils(); this.uploadHandler = null; this.splashScreenEl = null; @@ -183,6 +183,9 @@ export default class ActionBinder { this.multiFileValidationFailure = false; this.initialize(); this.experimentData = null; + this.experimentViaPageConfig = false; + this.pageConfigLocation = null; + this.pageConfigFetched = false; } async initialize() { @@ -225,11 +228,13 @@ export default class ActionBinder { } getAcrobatApiConfig() { + const base = this.pageConfigLocation ? `${this.pageConfigLocation}/api/v1` : unityConfig.apiEndPoint; unityConfig.acrobatEndpoint = { - createAsset: `${unityConfig.apiEndPoint}/asset`, - finalizeAsset: `${unityConfig.apiEndPoint}/asset/finalize`, - getMetadata: `${unityConfig.apiEndPoint}/asset/metadata`, + createAsset: `${base}/asset`, + finalizeAsset: `${base}/asset/finalize`, + getMetadata: `${base}/asset/metadata`, }; + unityConfig.connectorApiEndPoint = `${base}/asset/connector`; return unityConfig; } @@ -243,18 +248,6 @@ export default class ActionBinder { } async handlePreloads() { - if (!this.experimentData && this.workflowCfg.targetCfg?.experimentationOn?.includes(this.workflowCfg.enabledFeatures[0])) { - const { getExperimentData, getDecisionScopesForVerb } = await import('../../../utils/experiment-provider.js'); - try { - const decisionScopes = await getDecisionScopesForVerb(this.workflowCfg.enabledFeatures[0]); - this.experimentData = await getExperimentData(decisionScopes); - } catch (error) { - await this.dispatchErrorToast('warn_fetch_experiment', null, error.message, true, true, { - code: 'warn_fetch_experiment', - desc: error.message, - }); - } - } const parr = []; if (this.workflowCfg.targetCfg.showSplashScreen) { parr.push( @@ -264,6 +257,32 @@ export default class ActionBinder { await priorityLoad(parr); } + async ensurePageConfig() { + if (this.pageConfigFetched) return; + this.pageConfigFetched = true; + const verb = this.workflowCfg.enabledFeatures[0]; + try { + const { fetchPageConfig } = await import('../../../scripts/utils.js'); + const { default: getExperimentData } = await import('../../../utils/experiment-provider.js'); + const pageConfig = await fetchPageConfig({ product: 'acrobat', verb }); + this.pageConfigLocation = pageConfig.location; + if (pageConfig.config?.target?.enabled) { + this.experimentData = await getExperimentData(pageConfig.config.target.decisionScopes); + this.experimentViaPageConfig = true; + } else if (!this.experimentData && this.workflowCfg.targetCfg?.experimentationOn?.includes(verb)) { + const { getDecisionScopesForVerb } = await import('../../../utils/experiment-provider.js'); + const decisionScopes = await getDecisionScopesForVerb(verb); + this.experimentData = await getExperimentData(decisionScopes); + } + } catch (error) { + await this.dispatchErrorToast('warn_fetch_experiment', null, error.message, true, true, { + code: 'warn_fetch_experiment', + desc: error.message, + }); + } + this.acrobatApiConfig = this.getAcrobatApiConfig(); + } + async dispatchErrorToast(errorType, status, info = null, lanaOnly = false, showError = true, errorMetaData = {}) { if (!showError) return; const errorMessage = errorType in this.workflowCfg.errors @@ -458,7 +477,7 @@ export default class ActionBinder { redirectUrl = url.href; } } - this.redirectUrl = redirectUrl; + this.redirectUrl = redirectUrl; }) .catch(async (e) => { await this.showTransitionScreen(); @@ -487,7 +506,7 @@ export default class ActionBinder { if (this.multiFileValidationFailure) cOpts.payload.feedback = 'uploaderror'; if (this.showInfoToast) cOpts.payload.feedback = 'nonpdf'; } - if (this.workflowCfg.targetCfg?.experimentationOn?.includes(this.workflowCfg.enabledFeatures[0]) && this.experimentData) { + if (this.experimentData && (this.experimentViaPageConfig || this.workflowCfg.targetCfg?.experimentationOn?.includes(this.workflowCfg.enabledFeatures[0]))) { cOpts.payload.variationId = this.experimentData.variationId; } await this.getRedirectUrl(cOpts); @@ -557,6 +576,7 @@ export default class ActionBinder { if (prevalidatedFiles.length === 0) return; const { isValid, validFiles } = await this.validateFiles(prevalidatedFiles); if (!isValid) return; + await this.ensurePageConfig(); await this.initUploadHandler(); if (files.length === 1 || (validFiles.length === 1 && !verbsWithoutFallback.includes(this.workflowCfg.enabledFeatures[0]))) { await this.handleSingleFileUpload(validFiles); diff --git a/unitylibs/scripts/utils.js b/unitylibs/scripts/utils.js index 6e023f25c..8e573d33c 100644 --- a/unitylibs/scripts/utils.js +++ b/unitylibs/scripts/utils.js @@ -307,12 +307,14 @@ export const unityConfig = (() => { prod: { apiEndPoint: 'https://unity.adobe.io/api/v1', connectorApiEndPoint: 'https://unity.adobe.io/api/v1/asset/connector', + pageConfigEndPoint: 'https://cdn-unity.adobe.com/api/v1/pageConfig', env: 'prod', ...commoncfg, }, stage: { apiEndPoint: 'https://unity-stage.adobe.io/api/v1', connectorApiEndPoint: 'https://unity-stage.adobe.io/api/v1/asset/connector', + pageConfigEndPoint: 'https://cdn-unity.stage.adobe.com/api/v1/pageConfig', env: 'stage', ...commoncfg, }, @@ -345,3 +347,14 @@ export function sendAnalyticsEvent(event) { export function getMatchedDomain(domainMap = {}, hostname = window.location.hostname) { return Object.keys(domainMap).find((domain) => domainMap[domain].some((pattern) => new RegExp(pattern).test(hostname))); } + +export async function fetchPageConfig({ product, verb }) { + try { + const url = `${unityConfig.pageConfigEndPoint}?product=${product}&verb=${verb}`; + const resp = await fetch(url, { headers: { 'x-api-key': unityConfig.apiKey } }); + if (!resp.ok) throw new Error(`PageConfig fetch failed: ${resp.statusText}`); + return resp.json(); + } catch (e) { + return {}; + } +} diff --git a/unitylibs/utils/experiment-provider.js b/unitylibs/utils/experiment-provider.js index 013755c2c..f102ba724 100644 --- a/unitylibs/utils/experiment-provider.js +++ b/unitylibs/utils/experiment-provider.js @@ -1,11 +1,5 @@ /* eslint-disable no-underscore-dangle */ -export async function getDecisionScopesForVerb(verb) { - const region = await getRegion().catch(() => undefined); - const verbScope = `acom_unity_acrobat_${verb}`; - return region ? [`${verbScope}_${region}`, verbScope] : [verbScope]; -} - export async function getRegion() { const resp = await fetch('https://geo2.adobe.com/json/', { cache: 'no-cache' }); if (!resp.ok) throw new Error(`Failed to resolve region: ${resp.statusText}`); @@ -14,7 +8,13 @@ export async function getRegion() { return country.toLowerCase(); } -export async function getExperimentData(decisionScopes) { +export async function getDecisionScopesForVerb(verb) { + const region = await getRegion().catch(() => undefined); + const verbScope = `acom_unity_acrobat_${verb}`; + return region ? [`${verbScope}_${region}`, verbScope] : [verbScope]; +} + +export default async function getExperimentData(decisionScopes) { if (!decisionScopes || decisionScopes.length === 0) { throw new Error('No decision scopes provided for experiment data fetch'); } From bf76ad3669d9e47960416ae24b5d673b4b00b95d Mon Sep 17 00:00:00 2001 From: Arushi Gupta <65466846+arugupta1992@users.noreply.github.com> Date: Thu, 14 May 2026 14:46:49 +0530 Subject: [PATCH 2/7] MWPW-194869 : iPad/iPhone: Landscape image preview does not fully occupy upload container (#775) Resolves: [MWPW-194869](https://jira.corp.adobe.com/browse/MWPW-194869) **Test URLs:** - Before: https://main--da-cc--adobecom.aem.live/drafts/arugupta/image-to-video/doodlebug/image-to-video-actual?unitylibs=stage - After: https://main--da-cc--adobecom.aem.live/drafts/arugupta/image-to-video/doodlebug/image-to-video-actual?unitylibs=MWPW-194869 --------- Co-authored-by: Arushi Gupta Co-authored-by: Sanjay Saravanan <75960494+sanjayms01@users.noreply.github.com> Co-authored-by: Vipul Gupta Co-authored-by: vipulg Co-authored-by: Nishant Thakur Co-authored-by: Ratko Zagorac <90400759+zagi25@users.noreply.github.com> Co-authored-by: Ruchika Sinha <69535463+Ruchika4@users.noreply.github.com> Co-authored-by: Manasvi Agrawal --- .../widgets/prompt-bar-upload/prompt-bar-upload.css | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/unitylibs/core/widgets/prompt-bar-upload/prompt-bar-upload.css b/unitylibs/core/widgets/prompt-bar-upload/prompt-bar-upload.css index c48db813a..59a6db0a1 100644 --- a/unitylibs/core/widgets/prompt-bar-upload/prompt-bar-upload.css +++ b/unitylibs/core/widgets/prompt-bar-upload/prompt-bar-upload.css @@ -943,8 +943,7 @@ margin: 0; .pbu-preview { position: absolute; -top: 0; -left: 0; +inset: 0; width: 100%; height: 100%; box-sizing: border-box; @@ -958,11 +957,14 @@ display: none; .pbu-preview-img { display: block; -width: stretch; -height: stretch; +width: 100%; +height: 100%; +max-width: none; object-fit: cover; +object-position: center; border-radius: 13.667px; border: 2px solid #4069FD; +box-sizing: border-box; } .unity-prompt-bar-upload.unity-enabled .pbu-delete-btn { From 70e85d2bcc0e7af50d929beadc5f24023eed3a6b Mon Sep 17 00:00:00 2001 From: Ruchika Sinha <69535463+Ruchika4@users.noreply.github.com> Date: Wed, 13 May 2026 22:24:44 -0700 Subject: [PATCH 3/7] [MWPW-194995]Fix delay with config-based A/B testing api initiation (#778) * Fix delay with config-based A/B testing api initiation Resolves: [MWPW-194995(https://jira.corp.adobe.com/browse/MWPW-194995) **Test URLs:** - Before: https://stage--da-dc--adobecom.aem.page/acrobat/online/compress-pdf?martech=off&unitylibs=stage - After: https://stage--da-dc--adobecom.aem.page/acrobat/online/compress-pdf?martech=off&unitylibs=target-test **Implementation details:** `this.pageConfigPromise = null (line 189)` initializes the field so it's always defined on the instance. `this.pageConfigPromise = this.ensurePageConfig() `(line 792, inside initActionListeners when b === this.block) fires the fetch the moment the verb-widget finishes rendering (for performance reasons), no await so it doesn't block listener setup. The promise is stored so it can be joined later. `await (this.pageConfigPromise || this.ensurePageConfig()) `(line 580, in handleFileUpload) if the widget has rendered (normal path), we await the already in flight or resolved promise; if somehow pageConfigPromise is null (edge case: upload triggered before initActionListeners ran with the block), we fall back to calling it directly. The existing pageConfigFetched guard inside ensurePageConfig still prevents double execution. --------- Co-authored-by: Arushi Gupta <65466846+arugupta1992@users.noreply.github.com> Co-authored-by: Arushi Gupta Co-authored-by: Sanjay Saravanan <75960494+sanjayms01@users.noreply.github.com> Co-authored-by: Vipul Gupta Co-authored-by: vipulg Co-authored-by: Nishant Thakur Co-authored-by: Ratko Zagorac <90400759+zagi25@users.noreply.github.com> Co-authored-by: Manasvi Agrawal --- unitylibs/core/workflow/workflow-acrobat/action-binder.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/unitylibs/core/workflow/workflow-acrobat/action-binder.js b/unitylibs/core/workflow/workflow-acrobat/action-binder.js index e4343970b..2c50b7db8 100644 --- a/unitylibs/core/workflow/workflow-acrobat/action-binder.js +++ b/unitylibs/core/workflow/workflow-acrobat/action-binder.js @@ -186,6 +186,7 @@ export default class ActionBinder { this.experimentViaPageConfig = false; this.pageConfigLocation = null; this.pageConfigFetched = false; + this.pageConfigPromise = null; } async initialize() { @@ -576,7 +577,7 @@ export default class ActionBinder { if (prevalidatedFiles.length === 0) return; const { isValid, validFiles } = await this.validateFiles(prevalidatedFiles); if (!isValid) return; - await this.ensurePageConfig(); + await (this.pageConfigPromise || this.ensurePageConfig()); await this.initUploadHandler(); if (files.length === 1 || (validFiles.length === 1 && !verbsWithoutFallback.includes(this.workflowCfg.enabledFeatures[0]))) { await this.handleSingleFileUpload(validFiles); @@ -788,6 +789,7 @@ export default class ActionBinder { } if (b === this.block) { this.loadTransitionScreen(); + this.pageConfigPromise = this.ensurePageConfig(); } } } From 3ae352feb082348b49df0a814863105e12b56aaa Mon Sep 17 00:00:00 2001 From: Ruchika Sinha <69535463+Ruchika4@users.noreply.github.com> Date: Thu, 21 May 2026 10:51:37 -0700 Subject: [PATCH 4/7] Don't wait for finalize (#787) * Add your * Specific * Features or fixes Resolves: [MWPW-NUMBER](https://jira.corp.adobe.com/browse/MWPW-NUMBER) **Test URLs:** - Before: https://main--unity--adobecom.aem.page/?martech=off - After: https://--unity--adobecom.aem.page/?martech=off --------- Co-authored-by: Ruchika Sinha --- .../workflow-acrobat/upload-handler.js | 41 ++----------------- 1 file changed, 4 insertions(+), 37 deletions(-) diff --git a/unitylibs/core/workflow/workflow-acrobat/upload-handler.js b/unitylibs/core/workflow/workflow-acrobat/upload-handler.js index ba04bef4e..638faaa9d 100644 --- a/unitylibs/core/workflow/workflow-acrobat/upload-handler.js +++ b/unitylibs/core/workflow/workflow-acrobat/upload-handler.js @@ -211,46 +211,13 @@ export default class UploadHandler { this.actionBinder.getAdditionalHeaders() || {}, { body: JSON.stringify(finalAssetData), signal }, ); - const finalizeJson = await this.networkUtils.fetchFromServiceWithRetry( + finalizeOpts.keepalive = true; + this.networkUtils.fetchFromServiceWithRetry( this.actionBinder.acrobatApiConfig.acrobatEndpoint.finalizeAsset, finalizeOpts, this.actionBinder.workflowCfg.targetCfg.fetchApiConfig.finalizeAsset, - ); - if (!finalizeJson || Object.keys(finalizeJson).length !== 0) { - if (this.actionBinder.MULTI_FILE) { - await this.actionBinder.dispatchErrorToast('upload_error_finalize_asset', 500, `Unexpected response from finalize call: ${assetData.id}, ${JSON.stringify(finalizeJson || {})}`, false, true, { - code: 'upload_error_finalize_asset', - desc: `Unexpected response from finalize call: ${assetData.id}, ${JSON.stringify(finalizeJson || {})}`, - }); - return false; - } - await this.showSplashScreen(); - await this.actionBinder.dispatchErrorToast('upload_error_finalize_asset', 500, `Unexpected response from finalize call: ${assetData.id}, ${JSON.stringify(finalizeJson)}`, false, true, { - code: 'upload_error_finalize_asset', - desc: `Unexpected response from finalize call: ${assetData.id}, ${JSON.stringify(finalizeJson)}`, - }); - this.actionBinder.operations = []; - return false; - } - } catch (e) { - if (e.name === 'AbortError') return false; - if (this.actionBinder.MULTI_FILE) { - await this.actionBinder.dispatchErrorToast('upload_error_finalize_asset', e.status || 500, `Exception thrown when verifying content: ${e.message}, ${assetData.id}`, false, e.showError, { - code: 'upload_error_finalize_asset', - subCode: e.status, - desc: `Exception thrown when verifying content: ${e.message}, ${assetData.id}`, - }); - return false; - } - await this.showSplashScreen(); - await this.actionBinder.dispatchErrorToast('upload_error_finalize_asset', e.status || 500, `Exception thrown when verifying content: ${e.message}, ${assetData.id}`, false, e.showError, { - code: 'upload_error_finalize_asset', - subCode: e.status, - desc: `Exception thrown when verifying content: ${e.message}, ${assetData.id}`, - }); - this.actionBinder.operations = []; - return false; - } + ).catch(() => {}); + } catch (e) { /* fire-and-forget */ } return true; } From 0e219e5a8a5764b224c01484e16c8d77a549ae74 Mon Sep 17 00:00:00 2001 From: Arushi Gupta Date: Mon, 25 May 2026 12:51:19 +0530 Subject: [PATCH 5/7] removing retry in finalise call --- unitylibs/core/workflow/workflow-acrobat/upload-handler.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/unitylibs/core/workflow/workflow-acrobat/upload-handler.js b/unitylibs/core/workflow/workflow-acrobat/upload-handler.js index 638faaa9d..bf3dd71e2 100644 --- a/unitylibs/core/workflow/workflow-acrobat/upload-handler.js +++ b/unitylibs/core/workflow/workflow-acrobat/upload-handler.js @@ -212,10 +212,9 @@ export default class UploadHandler { { body: JSON.stringify(finalAssetData), signal }, ); finalizeOpts.keepalive = true; - this.networkUtils.fetchFromServiceWithRetry( + this.networkUtils.fetchFromService( this.actionBinder.acrobatApiConfig.acrobatEndpoint.finalizeAsset, - finalizeOpts, - this.actionBinder.workflowCfg.targetCfg.fetchApiConfig.finalizeAsset, + finalizeOpts ).catch(() => {}); } catch (e) { /* fire-and-forget */ } return true; From 9734c2dd2b61e424f8db726d0870e4329739244f Mon Sep 17 00:00:00 2001 From: Arushi Gupta Date: Mon, 25 May 2026 14:04:58 +0530 Subject: [PATCH 6/7] Adding await --- unitylibs/core/workflow/workflow-acrobat/upload-handler.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/unitylibs/core/workflow/workflow-acrobat/upload-handler.js b/unitylibs/core/workflow/workflow-acrobat/upload-handler.js index bf3dd71e2..f592e01e4 100644 --- a/unitylibs/core/workflow/workflow-acrobat/upload-handler.js +++ b/unitylibs/core/workflow/workflow-acrobat/upload-handler.js @@ -212,7 +212,7 @@ export default class UploadHandler { { body: JSON.stringify(finalAssetData), signal }, ); finalizeOpts.keepalive = true; - this.networkUtils.fetchFromService( + await this.networkUtils.fetchFromService( this.actionBinder.acrobatApiConfig.acrobatEndpoint.finalizeAsset, finalizeOpts ).catch(() => {}); From 99b394e5d024a562a9d55b6d9b1566c22277989f Mon Sep 17 00:00:00 2001 From: Arushi Gupta Date: Mon, 25 May 2026 15:53:33 +0530 Subject: [PATCH 7/7] Adding error handling, no retry on 202 only --- .../workflow-acrobat/target-config.json | 1 + .../workflow-acrobat/upload-handler.js | 45 ++++++++++++++++--- unitylibs/utils/NetworkUtils.js | 10 ++++- 3 files changed, 50 insertions(+), 6 deletions(-) diff --git a/unitylibs/core/workflow/workflow-acrobat/target-config.json b/unitylibs/core/workflow/workflow-acrobat/target-config.json index ab7f56ad4..99b2f2da5 100644 --- a/unitylibs/core/workflow/workflow-acrobat/target-config.json +++ b/unitylibs/core/workflow/workflow-acrobat/target-config.json @@ -22,6 +22,7 @@ "fetchApiConfig": { "finalizeAsset": { "retryType": "polling", + "retryOn202": false, "retryParams": { "maxRetryDelay": 300000, "defaultRetryDelay": 5000 diff --git a/unitylibs/core/workflow/workflow-acrobat/upload-handler.js b/unitylibs/core/workflow/workflow-acrobat/upload-handler.js index f592e01e4..de9a008e6 100644 --- a/unitylibs/core/workflow/workflow-acrobat/upload-handler.js +++ b/unitylibs/core/workflow/workflow-acrobat/upload-handler.js @@ -211,12 +211,47 @@ export default class UploadHandler { this.actionBinder.getAdditionalHeaders() || {}, { body: JSON.stringify(finalAssetData), signal }, ); - finalizeOpts.keepalive = true; - await this.networkUtils.fetchFromService( + const finalizeJson = await this.networkUtils.fetchFromServiceWithRetry( this.actionBinder.acrobatApiConfig.acrobatEndpoint.finalizeAsset, - finalizeOpts - ).catch(() => {}); - } catch (e) { /* fire-and-forget */ } + finalizeOpts, + this.actionBinder.workflowCfg.targetCfg.fetchApiConfig.finalizeAsset, + (responseJson) => responseJson, + ); + if (!finalizeJson || Object.keys(finalizeJson).length !== 0) { + if (this.actionBinder.MULTI_FILE) { + await this.actionBinder.dispatchErrorToast('upload_error_finalize_asset', 500, `Unexpected response from finalize call: ${assetData.id}, ${JSON.stringify(finalizeJson || {})}`, false, true, { + code: 'upload_error_finalize_asset', + desc: `Unexpected response from finalize call: ${assetData.id}, ${JSON.stringify(finalizeJson || {})}`, + }); + return false; + } + await this.showSplashScreen(); + await this.actionBinder.dispatchErrorToast('upload_error_finalize_asset', 500, `Unexpected response from finalize call: ${assetData.id}, ${JSON.stringify(finalizeJson)}`, false, true, { + code: 'upload_error_finalize_asset', + desc: `Unexpected response from finalize call: ${assetData.id}, ${JSON.stringify(finalizeJson)}`, + }); + this.actionBinder.operations = []; + return false; + } + } catch (e) { + if (e.name === 'AbortError') return false; + if (this.actionBinder.MULTI_FILE) { + await this.actionBinder.dispatchErrorToast('upload_error_finalize_asset', e.status || 500, `Exception thrown when verifying content: ${e.message}, ${assetData.id}`, false, e.showError, { + code: 'upload_error_finalize_asset', + subCode: e.status, + desc: `Exception thrown when verifying content: ${e.message}, ${assetData.id}`, + }); + return false; + } + await this.showSplashScreen(); + await this.actionBinder.dispatchErrorToast('upload_error_finalize_asset', e.status || 500, `Exception thrown when verifying content: ${e.message}, ${assetData.id}`, false, e.showError, { + code: 'upload_error_finalize_asset', + subCode: e.status, + desc: `Exception thrown when verifying content: ${e.message}, ${assetData.id}`, + }); + this.actionBinder.operations = []; + return false; + } return true; } diff --git a/unitylibs/utils/NetworkUtils.js b/unitylibs/utils/NetworkUtils.js index 555628b9e..20f7dff1b 100644 --- a/unitylibs/utils/NetworkUtils.js +++ b/unitylibs/utils/NetworkUtils.js @@ -122,6 +122,14 @@ export default class NetworkUtils { } } + shouldRetryPollingRequest(status, retryConfig, customRetryCheckResult) { + if (customRetryCheckResult) return true; + if (status >= 500 && status < 600) return true; + if (status === 429) return true; + if (status === 202 && retryConfig.retryOn202 !== false) return true; + return false; + } + async fetchFromServiceWithServerPollingRetry(url, options, retryConfig, onSuccess, onError) { const maxRetryDelay = retryConfig.retryParams?.maxRetryDelay || 300000; let timeLapsed = 0; @@ -133,7 +141,7 @@ export default class NetworkUtils { const { status, headers } = response; const responseJson = await this.getResponseJson(response); const customRetryCheckResult = retryConfig.extraRetryCheck && await retryConfig.extraRetryCheck(status, responseJson); - if (customRetryCheckResult || status === 202 || (status >= 500 && status < 600) || status === 429) { + if (this.shouldRetryPollingRequest(status, retryConfig, customRetryCheckResult)) { const retryDelay = (parseInt(headers.get('retry-after'), 10) * 1000) || retryConfig.retryParams?.defaultRetryDelay || 5000; await new Promise((resolve) => { setTimeout(resolve, retryDelay); }); timeLapsed += retryDelay;