diff --git a/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/admin.php b/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/admin.php index ef0d5741e6..39d1df7cf7 100644 --- a/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/admin.php +++ b/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/admin.php @@ -166,8 +166,8 @@ public static function add_notice_if_flagged_or_unflagged() { esc_attr( $notice_type ), sprintf( $notice, - 'https://profiles.wordpress.org/' . $user->user_nicename . '/', - sanitize_text_field( $user->display_name ) + esc_url( 'https://profiles.wordpress.org/' . $user->user_nicename . '/' ), + esc_html( $user->display_name ) ) ); } diff --git a/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/flagged.php b/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/flagged.php index 0dbaf44fe0..c9ed895941 100644 --- a/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/flagged.php +++ b/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/flagged.php @@ -286,7 +286,7 @@ public static function output_flagged_photos_count_to_author( $post ) { . sprintf( /* translators: %s: Count of user's flagged photos possibly linked to listing of their flagged photos. */ _n( 'Flagged: %s', 'Flagged: %s', $flagged_count, 'wporg-photos' ), - $flagged_link ? sprintf( '%d', $flagged_link, $flagged_count ) : $flagged_count + $flagged_link ? sprintf( '%d', esc_url( $flagged_link ), $flagged_count ) : $flagged_count ) . "\n"; } diff --git a/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/moderation.php b/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/moderation.php index 02ebbd447c..621b0ed1be 100644 --- a/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/moderation.php +++ b/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/moderation.php @@ -759,8 +759,8 @@ public static function output_list_of_pending_submissions_for_user( $content, $u foreach ( $pending as $post ) { $content .= sprintf( "%s%s%s\n", - get_post_meta( $post->ID, Registrations::get_meta_key( 'original_filename' ), true ) ?: __( "(unknown)", 'wporg-photos' ), - get_the_date( 'Y-m-d', $post ), + esc_html( get_post_meta( $post->ID, Registrations::get_meta_key( 'original_filename' ), true ) ?: __( '(unknown)', 'wporg-photos' ) ), + esc_html( get_the_date( 'Y-m-d', $post ) ), esc_html( get_the_content( null, false, $post ) ?: __( '(none provided)', 'wporg-photos' ) ), ); } diff --git a/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/photo.php b/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/photo.php index 2a119f2646..f2d5ebd514 100644 --- a/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/photo.php +++ b/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/photo.php @@ -956,6 +956,11 @@ public static function get_exif( $post_id, $exif_keys = [] ) { break; case 'iso': $label = 'ISO'; + // Cast to discard the arbitrary string EXIF can supply for this tag. + $value = (int) $value; + if ( 0 >= $value ) { + continue 2; + } break; case 'shutter_speed': $label = 'Shutter Speed'; @@ -1124,7 +1129,7 @@ public static function get_moderator_link( $post = null ) { $link = sprintf( '%s', esc_url( 'https://profiles.wordpress.org/' . $moderator->user_nicename . '/' ), - sanitize_text_field( $moderator->display_name ) + esc_html( $moderator->display_name ) ); } diff --git a/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/template-tags.php b/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/template-tags.php index 0a1ba29520..f09f0715a0 100644 --- a/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/template-tags.php +++ b/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/template-tags.php @@ -37,7 +37,7 @@ function show_colors( $post = 0, $echo = true ) { '%s', esc_attr( $color->slug ), esc_url( get_term_link( $color->slug, Registrations::get_taxonomy( 'colors' ) ) ), - $color->name + esc_html( $color->name ) ); } $output .= implode( ', ', $colors_output ); @@ -82,7 +82,7 @@ function show_categories( $post = 0, $echo = true ) { '%s', esc_attr( $cat->slug ), esc_url( get_term_link( $cat->slug, Registrations::get_taxonomy( 'categories' ) ) ), - $cat->name + esc_html( $cat->name ) ); } $output .= implode( ', ', $cats_output ); @@ -127,7 +127,7 @@ function show_tags( $post = 0, $echo = true ) { '
  • %s
  • ', esc_attr( $tag->slug ), esc_url( get_term_link( $tag->slug, Registrations::get_taxonomy( 'tags' ) ) ), - $tag->name + esc_html( $tag->name ) ); } @@ -206,8 +206,8 @@ function show_exif( $post = 0, $echo = true ) { $exif_output[] = sprintf( '
  • %s: %s
  • ', esc_attr( $key ), - $item['label'], - $item['value'] + esc_html( $item['label'] ), + esc_html( $item['value'] ) ); } $output .= implode( "\n", $exif_output );