add license header check

Author: VREMSoftwareDevelopment

.github/workflows/android-ci.yml

@@ -20,6 +20,14 @@ on:
   workflow_dispatch: {}
 
 jobs:
+  license-header:
+    runs-on: ubuntu-24.04
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v6
+      - name: license header check
+        run: ./scripts/check-license-headers.sh
+
   ktlint:
     runs-on: ubuntu-24.04
     steps:

AGENTS.md

@@ -22,38 +22,49 @@ WiFiAnalyzer is an Android application for analyzing WiFi networks. It helps use
 | Code Style | ktlint |
 | License | GNU General Public License v3.0 (GPLv3) |
 
-clearAdditional repository-specific versions and toolchain (source-of-truth files shown):
+Additional repository-specific versions and toolchain (source-of-truth files shown):
 
-- Kotlin: root `build.gradle` (look for `kotlin_version`)
-- Android Gradle Plugin (AGP): root `build.gradle` (look for the `com.android.tools.build:gradle` classpath)
+The build uses the Gradle Kotlin DSL (`*.gradle.kts`) with a **version catalog**. Every dependency, plugin,
+and tool version lives in `gradle/libs.versions.toml` — the build scripts only reference it via
+`libs.*` accessors and `alias(libs.plugins.*)`, so they contain no version literals.
+
+- All library, plugin, and tool versions (Kotlin, AGP, ktlint, Robolectric, ...): `gradle/libs.versions.toml`
 - Gradle wrapper: `gradle/wrapper/gradle-wrapper.properties` (check `distributionUrl`)
 - JDK used in CI: `.github/actions/common-setup/action.yml` and `.github/workflows/*` (search for `java-version` or `setup-java` usage)
-- Kotlin JVM target, compileSdk, minSdk: `app/build.gradle` (`kotlinOptions.jvmTarget`, `compileSdk`, `minSdkVersion` / `minSdk`)
-- ktlint plugin version: `app/build.gradle` (plugin `org.jlleitschuh.gradle.ktlint` and its `version`)
+- compileSdk, minSdk, targetSdk, Java source/target compatibility: `app/build.gradle.kts`
+- Version numbers and release signing: `app/gradle/version.gradle.kts` (values in `app/build.properties`)
+- JaCoCo tasks and coverage thresholds: `app/gradle/jacoco.gradle.kts`
+- Android lint rules: `app/lint.xml`; formatting rules: `.editorconfig`
+
+Do not use apply(from = ...). Prefer precompiled (convention) plugins or a `build-logic` module; this repository does not use Gradle `extra` properties.
 
 To extract these values quickly from a bash shell you can run (from the repository root):
 
 ```bash
-# Kotlin version
-grep -n "kotlin_version" build.gradle.kts
+# All versions at a glance
+cat gradle/libs.versions.toml
+
+# A specific version (Kotlin, AGP, ktlint, Robolectric, ...)
+grep -nE "^(agp|kotlin|ktlint|robolectric) = " gradle/libs.versions.toml
 
-# AGP classpath
-grep -n "com.android.tools.build:gradle" build.gradle.kts
+# Which plugins are applied, and where
+grep -nE "alias\(libs\.plugins" build.gradle.kts app/build.gradle.kts
 
 # Gradle wrapper distribution
 grep -n "distributionUrl" gradle/wrapper/gradle-wrapper.properties
 
 # JDK in CI workflows
-grep -R "java-version" .github
-
-# compileSdk / minSdk / jvmTarget / ktlint plugin
-grep -nE "compileSdk|minSdk|kotlinOptions.jvmTarget|org.jlleitschuh.gradle.ktlint" app/build.gradle.kts
+grep -Rn "java-version" .github
 
+# compileSdk / minSdk / targetSdk / Java compatibility
+grep -nE "compileSdk|minSdk|targetSdk|JavaVersion" app/build.gradle.kts
 ```
 
 ## Project Structure
 
 ```
+app/build.gradle.kts         # Module build script
+app/gradle/                  # Applied build scripts (version, jacoco)
 app/src/main/kotlin/         # Main application source code
 app/src/test/kotlin/         # Unit tests
 app/src/androidTest/kotlin/  # Android instrumentation tests
@@ -95,10 +106,11 @@ All source files must include the GPLv3 license header:
 Use ktlint for code formatting:
 - Check: `./gradlew ktlintCheck`
 - Format: `./gradlew ktlintFormat`
- 
+
 Repository-specific ktlint notes:
-- Plugin configured in `app/build.gradle` as `org.jlleitschuh.gradle.ktlint` (version `14.2.0`).
-- Baseline and rules: see `app/config/ktlint/baseline.xml` and project `.editorconfig` for formatting rules.
+- Plugin applied in `app/build.gradle.kts` as `alias(libs.plugins.ktlint)`; the version is the `ktlint` entry in `gradle/libs.versions.toml`.
+- Formatting rules: project `.editorconfig`. There is no ktlint baseline file — the codebase is expected to be clean.
+- `app/gradle/*.gradle.kts` is checked via `kotlinScriptAdditionalPaths`; ktlint otherwise sees only top-level `*.kts`.
 
 ## Communication Philosophy
 

app/build.properties

@@ -1,6 +1,6 @@
 #Build Properties
-#Mon Aug 17 18:59:46 EDT 2026
-version_build=4
+#Fri Aug 21 16:26:42 EDT 2026
+version_build=5
 version_major=3
 version_minor=3
 version_patch=1

app/lint.xml

@@ -1,4 +1,21 @@
 <?xml version="1.0" encoding="UTF-8"?>
+<!--
+  WiFiAnalyzer
+  Copyright (C) 2015 - 2026 VREM Software Development <VREMSoftwareDevelopment@gmail.com>
+
+  This program is free software: you can redistribute it and/or modify
+  it under the terms of the GNU General Public License as published by
+  the Free Software Foundation, either version 3 of the License, or
+  (at your option) any later version.
+
+  This program is distributed in the hope that it will be useful,
+  but WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+  GNU General Public License for more details.
+
+  You should have received a copy of the GNU General Public License
+  along with this program.  If not, see <http://www.gnu.org/licenses/>
+-->
 <lint>
     <issue id="GoogleAppIndexingWarning" severity="warning" />
 
@@ -11,4 +28,4 @@
         <ignore path="src/main/res/values-lt" />
         <ignore path="src/main/res/values-sk" />
     </issue>
-</lint>
+</lint>

app/src/main/AndroidManifest.xml

@@ -40,10 +40,6 @@
         android:supportsRtl="true"
         android:theme="@style/ThemeSplash">
 
-        <meta-data
-            android:name="android.max_aspect"
-            android:value="2.1" />
-
         <activity
             android:name=".MainActivity"
             android:configChanges="keyboardHidden|orientation|screenSize"

app/src/main/res/xml/test_attrs.xml

@@ -1,3 +1,20 @@
+<!--
+  WiFiAnalyzer
+  Copyright (C) 2015 - 2026 VREM Software Development <VREMSoftwareDevelopment@gmail.com>
+
+  This program is free software: you can redistribute it and/or modify
+  it under the terms of the GNU General Public License as published by
+  the Free Software Foundation, either version 3 of the License, or
+  (at your option) any later version.
+
+  This program is distributed in the hope that it will be useful,
+  but WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+  GNU General Public License for more details.
+
+  You should have received a copy of the GNU General Public License
+  along with this program.  If not, see <http://www.gnu.org/licenses/>
+-->
 <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android">
     <!-- Minimal content for AttributeSet testing -->
 </PreferenceScreen>

app/src/test/kotlin/com/vrem/wifianalyzer/MainRobolectricTest.kt

@@ -1,3 +1,20 @@
+/*
+ * WiFiAnalyzer
+ * Copyright (C) 2015 - 2026 VREM Software Development <VREMSoftwareDevelopment@gmail.com>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ */
 package com.vrem.wifianalyzer
 
 import android.Manifest

app/src/test/kotlin/com/vrem/wifianalyzer/wifi/model/FastRoamingTest.kt

@@ -1,3 +1,20 @@
+/*
+ * WiFiAnalyzer
+ * Copyright (C) 2015 - 2026 VREM Software Development <VREMSoftwareDevelopment@gmail.com>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ */
 package com.vrem.wifianalyzer.wifi.model
 
 import android.net.wifi.ScanResult

app/src/test/res/xml/test_attrs.xml

@@ -1,3 +1,20 @@
+<!--
+  WiFiAnalyzer
+  Copyright (C) 2015 - 2026 VREM Software Development <VREMSoftwareDevelopment@gmail.com>
+
+  This program is free software: you can redistribute it and/or modify
+  it under the terms of the GNU General Public License as published by
+  the Free Software Foundation, either version 3 of the License, or
+  (at your option) any later version.
+
+  This program is distributed in the hope that it will be useful,
+  but WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+  GNU General Public License for more details.
+
+  You should have received a copy of the GNU General Public License
+  along with this program.  If not, see <http://www.gnu.org/licenses/>
+-->
 <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android">
     <!-- Minimal content for AttributeSet testing -->
 </PreferenceScreen>

scripts/check-license-headers.sh

@@ -0,0 +1,30 @@
+#!/usr/bin/env bash
+#
+# Fails when a tracked source file is missing the GPLv3 license header.
+
+set -euo pipefail
+
+cd "$(git rev-parse --show-toplevel)"
+
+patterns=('*.java' '*.kt' '*.kts' '*.xml' '*.svg')
+header_lines=30
+
+missing=()
+while IFS= read -r -d '' file; do
+    header=$(head -n "$header_lines" "$file")
+    if ! grep -q 'VREM Software Development' <<<"$header" ||
+        ! grep -q 'GNU General Public License' <<<"$header"; then
+        missing+=("$file")
+    fi
+done < <(git ls-files -z "${patterns[@]}")
+
+if [ ${#missing[@]} -gt 0 ]; then
+    echo "ERROR: missing GPLv3 license header in ${#missing[@]} file(s):"
+    printf '  %s\n' "${missing[@]}"
+    if [ -n "${GITHUB_ACTIONS:-}" ]; then
+        printf '::error file=%s,line=1::Missing GPLv3 license header\n' "${missing[@]}"
+    fi
+    exit 1
+fi
+
+echo "GPLv3 license header present in all ${#patterns[@]} checked file types."