VPS-95/Fixed issue where pasting into input area would paste in slide#421
VPS-95/Fixed issue where pasting into input area would paste in slide#421kmck133 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds a helper function to detect when clipboard events target form input elements and applies that guard to three clipboard handlers. Copy, cut, and paste handlers now return early if the clipboard event originates from an INPUT or TEXTAREA, preventing editor clipboard logic from interfering with native form field behavior. ChangesForm Input Clipboard Guard
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
harbassan
left a comment
There was a problem hiding this comment.
yep works, clean implementation, nice 👍 😺
Issue
Pasting text into the scene name input field incorrectly pastes into the slide instead.
Solution
Added an isInputTarget guard to the global copy, cut, and paste clipboard handlers so they bail out early when the event target is an INPUT or TEXTAREA element, matching the same guard already in the keydown handler.
Risk
Low. The change only affects clipboard events originating from native input elements, which the global handlers should never have been handling.
Summary by CodeRabbit