Fix Utils module to not expect arguments for inspect

[bkuhlmann]

Why

Hello. 👋

The Liquid::Utils.inspect method expects an object argument but, when not given, it'll throw an ArgumentError. This violates the Liskov Substitution Principle becauseObject (superclass) does not require you pass in any arguments.

How

To fix, can the method signature be something like this?

self.inspect object = nil, seen = {}

This would allow object to be optional instead of requried.

Notes

I tried monkey patching with nil but ended up with different spec failures so not sure what the default expectation is here but this definitely causes specs to fail in CI when using SimpleCov 1.0.0. Although, when running locally, I could not recreate this.

[billkauf]

I'm seeing the same issue with simplecov 1.0.

(Monkey-patching also uncovers unrelated issues for me, so I probably won't upgrade simplecov for a while.)

[bkuhlmann]

If it helps, here's my monkey patch to work around the issue:

module Liquid
  # TODO: Remove once Liquid is patched. Broken since Liquid 5.13.0. Issue: 2107.
  module Utils
    def self.inspect(object = nil, seen = {}) = seen.empty? ? object.to_s : super

    def self.to_s(object = nil, seen = {}) = seen.empty? ? object.to_s : super
  end
end

I also spoke to Erik, over the weekend, and it sounds like he worked around this and will release SimpleCov 1.0.3 with a fix soon.

[billkauf]

Thanks! I did somewhat the same. Now, simplecov is breaking on integration with Datadog's CI tools...