Skip to content
This repository was archived by the owner on Jun 15, 2020. It is now read-only.
This repository was archived by the owner on Jun 15, 2020. It is now read-only.

Generated definitions are not usable in a browser #22

@tamird

Description

@tamird

Broken in 0c90364. That commit introduced hardcoded references to Buffer which is not defined in browsers, breaking Proto2TypeScript for non-Node environments.

From #13 (comment):

But we should definitely fix that. The flag to enable the node-only definitions is a good idea. The tests could also be improved, they were develop when I was the single user of the project, and they are far from perfect.

@kalbasit @yellowiscool

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions