Skip to content

CodeRabbit retains resolved findings in merge-risk assessment after full review #1352

Description

@coderabbitai

Summary

CodeRabbit can retain obsolete merge-risk findings after a new commit fixes the findings and a full review completes.

Reproduction context

Affected pull request: #1348

The latest commit fixed the projection-related findings in scene/2d/mode7_sprite_2d.cpp:

  • Gamma calculation uses Math::pow.
  • mode7_projection_aspect_ratio rejects zero values.
  • Projection setters use _mode7_refresh_projection_table(), which rebuilds the scanline texture and calls queue_redraw().

A full CodeRabbit review completed after these changes. The merge-risk assessment identified the latest commit, but still stated that the resolved projection issues remained present.

Expected behavior

When a full review evaluates the current PR head, the merge-risk assessment must use the findings from that revision only. It must remove or update claims for issues that the current head resolves.

Actual behavior

The merge-risk assessment retained claims from an earlier revision after the full review evaluated a newer commit that fixed those issues.

Affected area

CodeRabbit review-state and merge-risk assessment generation for pull requests.

Acceptance criteria

  • A full review recalculates the merge-risk assessment from the reviewed PR head.
  • Resolved findings do not remain in the merge-risk assessment.
  • The merge-risk text and the evaluated commit state remain consistent.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions