[TRTLLM-13694][infra] Add benchmark refresh mappings - #17317
Conversation
|
/bot run |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds a version 2 benchmark refresh mapping configuration. The configuration defines output defaults, B200/H200 mappings, and refresh targets for DeepSeek-R1 FP4/FP8 and GPT-OSS-120B FP4. ChangesBenchmark refresh configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR adds benchmark refresh mappings without any identified merge-blocking correctness, security, availability, or deployment risk; it is merge-ready after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #64709 [ run ] triggered by Bot. Commit: |
|
PR_Github #64709 [ run ] completed with state
|
|
/bot run |
|
PR_Github #64726 [ run ] triggered by Bot. Commit: |
|
PR_Github #64726 [ run ] completed with state
|
|
/bot run |
|
PR_Github #65113 [ run ] triggered by Bot. Commit: |
|
PR_Github #65113 [ run ] completed with state
|
|
/bot run |
|
PR_Github #65155 [ run ] triggered by Bot. Commit: |
|
PR_Github #65155 [ run ] completed with state
|
|
/bot run |
1 similar comment
|
/bot run |
|
PR_Github #65264 [ run ] triggered by Bot. Commit: |
|
PR_Github #65266 [ run ] triggered by Bot. Commit: |
|
PR_Github #65264 [ run ] completed with state |
|
PR_Github #65266 [ run ] completed with state
|
|
/bot run |
|
PR_Github #65376 [ run ] triggered by Bot. Commit: |
|
PR_Github #65376 [ run ] completed with state
|
|
/bot run |
|
PR_Github #65402 [ run ] triggered by Bot. Commit: |
|
/bot run |
|
PR_Github #65913 [ run ] triggered by Bot. Commit: |
|
PR_Github #65913 [ run ] completed with state
|
|
/bot run |
|
PR_Github #66050 [ run ] triggered by Bot. Commit: |
|
PR_Github #66050 [ run ] completed with state
|
|
/bot run |
|
PR_Github #66061 [ run ] triggered by Bot. Commit: |
|
PR_Github #66061 [ run ] completed with state
|
|
/bot run |
|
PR_Github #66155 [ run ] triggered by Bot. Commit: |
|
PR_Github #66155 [ run ] completed with state
|
|
/bot run |
|
PR_Github #66180 [ run ] triggered by Bot. Commit: |
|
PR_Github #66180 [ run ] completed with state
|
|
/bot run |
|
PR_Github #66280 [ run ] triggered by Bot. Commit: |
|
PR_Github #66280 [ run ] completed with state
|
Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
d61f6a6 to
7666c5c
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/bot run |
|
PR_Github #66380 [ run ] triggered by Bot. Commit: |
|
PR_Github #66380 [ run ] completed with state
|
|
/bot run |
|
PR_Github #66406 [ run ] triggered by Bot. Commit: |
|
PR_Github #66406 [ run ] completed with state |
Description
Add a repository-owned mapping file that defines which model, GPU, and precision groups may be refreshed from the latest validated benchmark data.
The file groups repeated accelerator translations and target path rules into shared defaults, so adding a model normally requires only its source model and precision, public target model and architecture, and GPU list. It also documents how generated recipes are stored, how to add or remove models and GPUs, and how to override the defaults when necessary.
Artifact logs are discovered automatically from each record's runtime dimensions. An optional
artifact_log.match_tokensoverride is available only when multiple complete logs remain ambiguous.Test Coverage
examples/configs/database/lookup.yaml.PR Checklist
Dev Engineer Review
lookup.yaml.QA Engineer Review
No test changes.