Remove legacy indexer

[naoyam]

This PR just removes the code for the legacy indexer. There should be no functional difference.

[naoyam]

!test

[naoyam]

!test

[naoyam]

!test --diff

[naoyam]

!test --diff

[naoyam]

!test --diff

[naoyam]

!test --diff

[greptile-apps]

Greptile Summary

This PR removes the legacy IndexCompute-based indexer (~3500+ lines across csrc/index_compute.h/cpp and csrc/device_lower/analysis/index_compute.h/cpp), along with associated infrastructure (IndexMagicZeroInfo, protectPredicateIndexWithMagicZero, protectNonPredicateIndexWithMagicZero, IndexFromIdGraph, LoopIndexing). All predicate and index lowering code now exclusively routes through TensorIndexer, removing the legacy fallback conditionals that checked isTensorIndexerEnabled(). A secondary std::ranges:: modernization pass is included across several files.

Confidence Score: 5/5

Safe to merge — this is a pure deletion of dead legacy code with no functional changes

All findings are P2 or lower. The legacy indexer was already fully superseded by TensorIndexer (enabled by default), the conditional fallback branches are correctly removed, and the CMakeLists entry is cleaned up. No new logic is introduced.

No files require special attention; all changes are straightforward deletions and minor modernization

Important Files Changed

Filename	Overview
csrc/index_compute.h	Removed IndexCompute class (~300 lines) and standalone free functions; only PredicateInfo, Index, and PredicateDomainInfo remain
csrc/index_compute.cpp	Removed ~1936 lines of legacy IndexCompute implementation; remaining functions assert isTensorIndexerEnabled and delegate to TensorIndexer
csrc/device_lower/analysis/index_compute.cpp	Entire file deleted (~1407 lines): all LoopIndexing/IndexFromIdGraph infrastructure and related helpers removed
csrc/device_lower/analysis/index_compute.h	Header for deleted file fully removed
csrc/predicate_compute.cpp	Removed conditional fallback to legacy indexer in getInlinePredicate and predicateOn; also modernized std:: to std::ranges:: throughout
csrc/device_lower/pass/magic_zero.h	Removed IndexMagicZeroInfo struct, protectPredicateIndexWithMagicZero, and protectNonPredicateIndexWithMagicZero—all legacy-indexer-only APIs
csrc/device_lower/pass/magic_zero.cpp	Deleted implementations of the two magic-zero protection helpers that were only used by the legacy indexer
csrc/device_lower/pass/rng.cpp	Removed legacy header include, added NOLINTNEXTLINE for const reference member, modernized std::any_of to std::ranges::any_of
csrc/device_lower/analysis/sync_information.cpp	Removed legacy header include; std::transform/std::sort modernized to std::ranges equivalents
csrc/id_model/indexing_utils.h	Removed legacy header include; std::find_if modernized to std::ranges::find_if
CMakeLists.txt	Removed device_lower/analysis/index_compute.cpp from the build source list to match file deletion

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Index / Predicate Lowering Request] --> B{isTensorIndexerEnabled?}
    B -- Before PR: true --> C[TensorIndexer path]
    B -- Before PR: false --> D[Legacy IndexCompute path]
    D --> E[IndexFromIdGraph / LoopIndexing]
    E --> F[protectPredicateIndexWithMagicZero]
    C --> G[TensorIndexer.getPredicates]
    C --> H[TensorIndexer.getIndexFor]
    B -- After PR: always true --> C
    D -. REMOVED .- D
    E -. REMOVED .- E
    F -. REMOVED .- F
    style D fill:#ffcccc,stroke:#cc0000
    style E fill:#ffcccc,stroke:#cc0000
    style F fill:#ffcccc,stroke:#cc0000

Loading

_{Reviews (1): Last reviewed commit: "clang-tidy" | Re-trigger Greptile}

[jacobhinkle]

LGTM 🚀