Missing FLAC encoder/decoder in official Windows binaries starting from 0.24.8

[0x0003]

Bug report

Describe the bug

Precompiled MPD binary for Windows (https://www.musicpd.org/download/win32/) doesn't have FLAC support.

$ mpd --version | grep flac
<no output>

The issue was already filed #2463, but the author closed it as completed citing the ability to crosscompile, which isn't really a solution. There's an oversight in build configuration somewhere that has to be fixed properly.

Expected Behavior

MPD can decode FLAC.

Actual Behavior

MPD cannot decode FLAC.

Version

Every version starting from 0.24.8

Configuration

Not relevant.

[MaxKellermann]

"Missing" and "oversight" implies somebody made a mistake. That's not the kind of rhethoric that will make somebody else (who doesn't even use/have Windows) invest free time in making you happy.
In reality, nobody made a mistake. It's just that nobody cared enough to implement this. If you care: take the time, implement this, send PR.

[0x0003]

I don't deal with compiling natively on windows either is the thing. Somebody did write native windows builds though, and CI too? Wouldn't that person be open to help?

Best PR I could offer is to switch windows builds to cross-compiled executables (could also bump the ancient libid3tag to current version), but the binaries produced are ~350MB in size due to static linking, I don't think that's at all reasonable. Just saw that build.py --buildtype=release doesn't run strip.

---

Either way, I'm not saying you "FIX IT NAO", sorry if it came out that way.
I just think the issue should stay open because it's not really resolved, author of the previous one shouldn't've closed theirs.

[MaxKellermann]

I'm that person, but decide supporting Windows is not worth my free time. But you are interested in having that feature, so it should be worth your time. If you don't do it, chances are high nobody will.

[0x0003]

I can't for the life of me figure out what's wrong.
I went over mingw https://github.com/MusicPlayerDaemon/MPD/actions/runs/29084834516/job/86335993395 and msys https://github.com/MusicPlayerDaemon/MPD/actions/runs/29084834459/job/86335993380 logs, both clearly have FLAC.

But the latest binaries from https://www.musicpd.org/download/win32/ do not

strings mpd-0.24.6.exe | grep -c 'FLAC__STREAM_DECODER_\|FLAC__STREAM_ENCODER_\|reference libFLAC' # last version with FLAC support
75

strings mpd-0.24.13.exe | grep -c 'FLAC__STREAM_DECODER_\|FLAC__STREAM_ENCODER_\|reference libFLAC'
0

Are the binaries published on the website not produced by github actions?

[MaxKellermann]

Are the binaries published on the website not produced by github actions?

No, they're not.

[0x0003]

Well, that explains it somewhat. Nothing I can see that can really be done from my end - went over the website repo, there's no clear CI/CD for windows binaries in there.
Could you go over what differs between github actions and your local build when you have the free time, please? I'd appreciate that.