Skip to content

chore: Disallow Git dependencies#4000

Merged
FrederikBolding merged 3 commits into
mainfrom
fb/disalllow-git-deps
May 12, 2026
Merged

chore: Disallow Git dependencies#4000
FrederikBolding merged 3 commits into
mainfrom
fb/disalllow-git-deps

Conversation

@FrederikBolding
Copy link
Copy Markdown
Member

@FrederikBolding FrederikBolding commented May 12, 2026

Disallow Git dependencies after bumping Yarn to the latest version.


Note

Low Risk
Low risk config hardening: it only changes Yarn settings to prevent installing Git URL dependencies, which may cause installs to fail only if such dependencies are introduced.

Overview
Adds Yarn configuration to disallow all Git-based dependencies by setting approvedGitRepositories: [] in .yarnrc.yml, tightening supply-chain security for installs.

Reviewed by Cursor Bugbot for commit 246828e. Bugbot is set up for automated code reviews on this repo. Configure here.

@FrederikBolding FrederikBolding requested a review from a team as a code owner May 12, 2026 09:21
@FrederikBolding FrederikBolding requested a review from Mrtenz May 12, 2026 09:21
Comment thread .yarnrc.yml
- lavamoat-core
- lavamoat-tofu

plugins:
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yarn automatically reordered these

Comment thread .yarnrc.yml Outdated
Co-authored-by: Maarten Zuidhoorn <[email protected]>
Mrtenz
Mrtenz previously approved these changes May 12, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.58%. Comparing base (84c2d21) to head (246828e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4000   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files         425      425           
  Lines       12368    12368           
  Branches     1949     1949           
=======================================
  Hits        12193    12193           
  Misses        175      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding added this pull request to the merge queue May 12, 2026
Merged via the queue into main with commit a7521ae May 12, 2026
129 checks passed
@FrederikBolding FrederikBolding deleted the fb/disalllow-git-deps branch May 12, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants