Skip to content

More consistent use of JetSpace - #200

Merged
lbenet merged 4 commits into
masterfrom
lb/improvsTS
Jul 2, 2026
Merged

lbenet merged 4 commits into
masterfrom
lb/improvsTS

Conversation

@lbenet

@lbenet lbenet commented Jul 1, 2026

Copy link
Copy Markdown
Member

This PR imposes a more consistent use of JetSpaces in TaylorModels. Among other, it's aimed to improve the performance.

@lbenet

lbenet commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

Tests are somehow not passing because the last version of TaylorSeries is not used; see this line...

@schillic

schillic commented Jul 2, 2026

Copy link
Copy Markdown
Member

It looks like it is not aware of a new version because there is no ⌅ sign. Sometimes it can take a while for the registry to update. Maybe just try again.

@lbenet

lbenet commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

Thanks for the comment. I think it is something deeper, in the sense that Pkg.update locally doesn't update it either. Anyways, I'll run again the tests to see if it works now.

@schillic

schillic commented Jul 2, 2026

Copy link
Copy Markdown
Member

Indeed, I also only see v0.22.2 locally. Not sure what to do about that. The registry seems to have it registered correctly. So not sure what can be done. I remember that there were similar problems some months ago that took maybe even a few days (not sure anymore). Probably you have to wait.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 28520221696

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage decreased (-0.4%) to 71.442%

Details

  • Coverage decreased (-0.4%) from the base build.
  • Patch coverage: 8 uncovered changes across 3 files (24 of 32 lines covered, 75.0%).
  • 2 coverage regressions across 1 file.

Uncovered Changes

File Changed Covered %
src/auxiliary.jl 8 2 25.0%
src/rpa_functions.jl 2 1 50.0%
src/valid_integ/integ_utils.jl 2 1 50.0%
Total (8 files) 32 24 75.0%

Coverage Regressions

2 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
src/constructors.jl 2 95.35%

Coverage Stats

Coverage Status
Relevant Lines: 2157
Covered Lines: 1541
Line Coverage: 71.44%
Coverage Strength: 214918.92 hits per line

💛 - Coveralls

@lbenet

lbenet commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

Locally I was able to update the TaylorSeries version, and the tests pass not, but something odd is happening now with coveralls... I'll get into it later...

@schillic

schillic commented Jul 2, 2026

Copy link
Copy Markdown
Member

You use some outdated actions, maybe that is related. Consider installing dependabot. It will keep your scripts up-to-date.

@lbenet

lbenet commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

The actual tests pass, so I'll go ahead and merge

@lbenet
lbenet merged commit 40a36c2 into master Jul 2, 2026
9 of 62 checks passed
@lbenet
lbenet deleted the lb/improvsTS branch July 2, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants