Skip to content

feat: VoteDuration에 HOURS_96(96시간) 추가 - #257

Merged
Junhyukkkk merged 1 commit into
developfrom
feat/add-96-hour
Jun 29, 2026
Merged

Junhyukkkk merged 1 commit into
developfrom
feat/add-96-hour

Conversation

@Junhyukkkk

@Junhyukkkk Junhyukkkk commented Jun 29, 2026 •

Copy link
Copy Markdown
Member

📌 관련 이슈

  • closes #

🔍 작업 내용

투표 생성 시 선택 가능한 기간에 96시간(4일) 옵션을 추가합니다.

📝 변경 사항

  • VoteDuration enum에 HOURS_96(Duration.ofHours(96)) 추가

💬 리뷰어에게

  • 기존 HOURS_48 추가와 동일한 추가(additive) 변경입니다.
  • DB 마이그레이션 불필요(투표는 duration 컬럼이 아니라 end_at만 저장).
  • fromHours()·기존 enum 값·VoteDurationTest에 영향 없습니다.

Summary by CodeRabbit

  • 새 기능
    • 투표 기간 선택 항목에 96시간 옵션이 추가되었습니다.
    • 이제 72시간을 넘어 더 긴 투표 기간을 설정할 수 있습니다.

@Junhyukkkk
Junhyukkkk merged commit 8bdf61e into develop Jun 29, 2026
2 of 3 checks passed
@coderabbitai

coderabbitai Bot commented Jun 29, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7fde3f11-ccf4-47bf-8f03-683256f5a43f

📥 Commits

Reviewing files that changed from the base of the PR and between 86800c4 and 51d894d.

📒 Files selected for processing (1)
  • src/main/java/com/ject/vs/vote/domain/VoteDuration.java

Walkthrough

VoteDuration enum에 HOURS_96(Duration.ofHours(96)) 상수가 추가되었습니다. 기존 HOURS_72 뒤에 위치하며, fromHours(96) 호출 시 해당 상수를 반환합니다.

Changes

VoteDuration 96시간 상수 추가

Layer / File(s) Summary
HOURS_96 enum 상수 추가
src/main/java/com/ject/vs/vote/domain/VoteDuration.java
HOURS_72 다음에 HOURS_96(Duration.ofHours(96)) 상수를 추가하여 96시간 투표 기간을 지원합니다.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • KII1ua

Poem

🐰 토끼가 시계를 보며 깡충깡충~
72시간도 모자라서
96시간을 추가했네!
투표 시간이 늘어났으니
더 많이 참여해봐요! 🗳️

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/add-96-hour

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Junhyukkkk
Junhyukkkk deleted the feat/add-96-hour branch June 29, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant