[Invoices]: Add consecutive position numbering to invoice line items

[xam-ps]

SMART Plan — [Invoices] Consecutive position numbers on invoice line items

Specific

Add a company setting "Show position numbers on line items" (boolean toggle, default off). When enabled, each invoice line item displays an auto-incrementing position number in both the invoice edit form and on the printed/PDF invoice. The position is display-only — no stored column required.

Measurable

• Company settings has a toggle: show_line_item_position_numbers.
• When enabled, the invoice edit form's item repeater shows a read-only position indicator (1, 2, 3…).
• The PDF template renders a position column when the setting is on, and omits it when off.
• PHPUnit confirms the setting persists and the toggle renders on the settings form.

Achievable

1. Add a boolean setting show_line_item_position_numbers to the company settings Filament schema.
2. In the invoice items Repeater, conditionally prepend a read-only Placeholder component when the setting is enabled.
3. In the PDF blade template, wrap the position column with @if($company->getSetting('show_line_item_position_numbers')).

Relevant

Position numbering is a legal requirement in Germany and other EU jurisdictions — each line item must have a consecutive reference number for bookkeeping and dispute resolution.

Time-bound

Sprint 5.

---

Arrange · Act · Assert

#[Test]
public function it_persists_the_show_position_numbers_setting(): void
{
    /* Arrange */
    // AbstractCompanyPanelTestCase provides $this->company and $this->user

    /* Act */
    $component = Livewire::actingAs($this->user)
        ->test(\Modules\Core\Filament\Company\Pages\Settings\CompanySettings::class, [
            'tenant' => Str::lower($this->company->search_code),
        ])
        ->fillForm(['show_line_item_position_numbers' => true])
        ->call('save');

    /* Assert */
    $component->assertSuccessful();
    $this->assertTrue(
        (bool) $this->company->fresh()->getSetting('show_line_item_position_numbers')
    );
}

[nielsdrost7]

@xam-ps thank you for the feature request.
Check out the field invoice_order (if I'm not mistaking) in the invoices table.
If you just put the number from that field on your invoice template then you won't have to come up with a new field (and a setting)

Hope it helps!

[xam-ps]

@nielsdrost7
Sorry, for not being clear her: I want for every invoice to have a new numbering. So every first position of every new invoice should have 1), every second position 2) etc.

Best case IMO would be, to somewhere (either ipconfig.php or better in the settings, e.g. invoice section) have to option to activate and deactivate the numbering of the positions in the invoice. Hope it's a little bit clearer now.

[trogper]

You mean the items in invoice should be numbered?
That should be very easily done by editing the web and pdf templates. You don't need any custom fields for that.

[xam-ps]

Jep, I did that already for my IP instance. I was just wondering, if this is sth. were we could add an option in the settings, because I'm quite sure, that this is sth. that should be relevant for other people as well.

[pumpi]

The invoice templates exists to override with your own template, and you can select your own template in the settings. This is hard-coding, this is the way to go to create a template that fits your own requirements (https://wiki.invoiceplane.com/en/1.6/templates/using-templates).
The consequent numbering can easily add in the template and I think there is no config or feature needed for this 🙈

[nielsdrost7]

I'll help you with this on Slack.
I've moved the issue itself to Version 2 of InvoicePlane to make it more clear

[nielsdrost7]

Planning Note — v2 Implementation

Story: As a company admin in Germany (or any country requiring it), I want an option to automatically number invoice line items consecutively (1, 2, 3, …), so that my invoices comply with legal requirements without manually maintaining position numbers.

v2 context: InvoiceItem records have an item_order sort field. Consecutive position numbers are a display/rendering concern — they don't need to be stored as a separate DB field; they can be rendered from the 1-indexed position of the item in the sorted items collection.

Acceptance Criteria:

• A company setting "Show position numbers on invoice lines" (boolean, default off) is available in Settings → Invoice Settings.
• When enabled, the invoice PDF and guest view render a "#" column before each line item, numbered 1, 2, 3, … in item_order.
• The numbering is rendered at PDF/view time (not stored in the DB).
• The invoice edit form also shows the position number next to each item row as a visual reference.
• Quotes use the same setting (a single "Show position numbers on document lines" setting).

Implementation:

• Add show_item_position_numbers (boolean) to company settings.
• In the invoice PDF blade: @if($settings->show_item_position_numbers) — add <td>{{ $loop->iteration }}</td>.
• In the Filament invoice edit Repeater: add a read-only TextInput::make('position')->disabled()->default(fn ($get, $set, $state, $livewire) => $loop->index + 1) (or a JS-driven display).

Test Scenarios (PHPUnit):

// Position numbers appear in PDF when setting enabled
/* Arrange */ $this->company->settings()->update(['show_item_position_numbers' => true]);
              $invoice = Invoice::factory()->for($this->company)->has(InvoiceItem::factory()->count(3), 'invoiceItems')->create();
/* Act */     $html = app(InvoiceService::class)->renderPdfHtml($invoice);
/* Assert */  $this->assertStringContainsString('>1<', $html); // first position number
              $this->assertStringContainsString('>3<', $html); // third position number

// Position numbers absent when setting disabled
/* Arrange */ $this->company->settings()->update(['show_item_position_numbers' => false]);
              $invoice = Invoice::factory()->for($this->company)->has(InvoiceItem::factory()->count(2), 'invoiceItems')->create();
/* Act */     $html = app(InvoiceService::class)->renderPdfHtml($invoice);
/* Assert */  $this->assertStringNotContainsString('data-position-col', $html);

---

Generated by Claude Code

[nielsdrost7]

Test Suggestions

Added to support future implementation of this request. The issue body contains a complete SMART Plan.

The issue frames adding a show_line_item_position_numbers company setting and conditionally rendering position numbers in forms and PDF templates. Note: a comment suggests the field invoice_order may already exist and could be reused — verify whether this refers to a position column or something else before implementing.

Here are additional edge cases:

• PHPUnit: it_does_not_show_position_numbers_when_the_setting_is_off()

#[Test]
public function it_does_not_show_position_numbers_when_the_setting_is_off(): void
{
    /* Arrange */
    $this->company->setSetting('show_line_item_position_numbers', false);

    $invoice = Invoice::factory()->for($this->company)
        ->has(InvoiceItem::factory()->count(3), 'invoiceItems')
        ->create();

    /* Act */
    $component = Livewire::actingAs($this->user)
        ->test(EditInvoice::class, [
            'record' => $invoice->getRouteKey(),
            'tenant' => Str::lower($this->company->search_code),
        ]);

    /* Assert */
    $component->assertDontSee('Position');
    $component->assertDontSee('1.'); // Expects no position numbers
}

• PHPUnit: it_renders_consecutive_position_numbers_in_the_invoice_repeater()

#[Test]
public function it_renders_consecutive_position_numbers_in_the_invoice_repeater(): void
{
    /* Arrange */
    $this->company->setSetting('show_line_item_position_numbers', true);

    $invoice = Invoice::factory()->for($this->company)
        ->has(InvoiceItem::factory()->count(5), 'invoiceItems')
        ->create();

    /* Act */
    $component = Livewire::actingAs($this->user)
        ->test(EditInvoice::class, [
            'record' => $invoice->getRouteKey(),
            'tenant' => Str::lower($this->company->search_code),
        ]);

    /* Assert */
    $component->assertSee('1.');
    $component->assertSee('2.');
    $component->assertSee('5.');
}

• Edge case: When a line item is deleted mid-form, do the remaining position numbers automatically re-sequence (e.g. 1, 2, 4 becomes 1, 2, 3)? Or do they stay fixed to preserve a user's edits?

[nielsdrost7]

Correction: this issue already has an open PR implementing it — #683 (codex/invoice-line-numbering-370, "[IP-370]: invoice line numbering"). The test-suggestions comment above was posted in error by an automated grooming pass that missed the PR (its title-only reference wasn't caught by a body-only search). Please review against #683 instead of treating this as unaddressed.