Repository navigation
docs(changelog): Correct the audit-dedup reconciler attribution - #20
Merged
Merged
Conversation
The shipped entry claimed no audit-dedup reconciler existed. One does: corpflow's skills/agent-coordination/scripts/audit-dedup.sh, which keeps the hook:* row and drops agent rows sharing a dedupe_key. It is a read-time filter invoked only by /cost-report, not the automatic "audit-dedup hook" the hook headers name — so the duplicate rows do still accumulate on disk in full, and every reader other than /cost-report still pays for them. The symptom and the fix are unchanged; only the justification was wrong, and it was wrong in a way that could send a maintainer off to build a reconciler that already exists. Also notes that the write-time drop is consistent with audit-dedup.sh: the canonical hook:* row is never suppressed, so a later read-time dedup resolves every group identically. No code change, no version bump — this corrects the description of an already-released entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The changelog entry shipped with the audit-dedup fix states that "the header comment in both hooks promised that 'the orchestrator's audit-dedup hook' would reconcile these rows, but no such hook exists."
That is wrong. A reconciler does exist — corpflow's
skills/agent-coordination/scripts/audit-dedup.sh:It has contract tests (
tests/shell/skills/agent-coordination__audit-dedup.bats) and a--self-test.What was actually true
It is a read-time filter invoked only by
/cost-report, to avoid double-counting effort in aggregation. It is not a hook and does not run automatically. So the duplicate rows still accumulate on disk in full, and every other reader of the trail — the retrospective,refine-branch-target.sh,publish-pl-issue.sh, anyone grepping — still pays for them.The hook headers are a misnomer on two counts: what they name an "audit-dedup hook" is neither a hook nor automatic.
What is unchanged
audit-dedup.sh— the canonicalhook:*row is never suppressed by the write-time check, so a later read-time dedup still resolves every group the same way. Verified against the script's stated contract.Only the justification was wrong, and wrong in a way that could send a maintainer off to build something that already exists — which is why it is worth correcting in the durable record rather than only in a report.
Changes
CHANGELOG.mdonly. No code change, no version bump: this corrects the description of an already-released entry.Test plan
Documentation-only; no behaviour to test. The underlying fix was verified when it shipped: six plugin hooks driven with one payload produced 1 row (was 6); three distinct payloads produced 3 rows (no over-suppression); an advisory-then-canonical pair produced 2 rows with the canonical row present; 12/12 hook self-tests pass.
Notes
Found while locating the bats suites that cover corpflow PR #300 — the existence of
agent-coordination__audit-dedup.batsis what surfaced the error.