Skip to content

Bug: feature-flag hierachy #612

@L03TJ3

Description

@L03TJ3

Description

there is a complexity with using the feature-flags as intended.
Considering the new re-own update, where we want to rely on network enabled returned from the feature-flag
but as it is we cannot gracefully handle this because of chainId dependency.

Solution

in the main index.tsx we build up a long list of context providers.
In the current hierarchy its like:
... other providers

... other providers

  • Remove depdency on chainId in GoodDAppFeatureProvider
  • Provide seperate helper/utility for isFeatureActive
  • Move GoodDAppFeatureProvider to wrap AppKit
  • replace where relevant usages of isFeatureActive

Originally posted by @L03TJ3 in #604 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions