Skip to content

Using ispyb.open causes ispyb.model deprecation warning #179

@ndevenish

Description

@ndevenish

ispyb.open imports:

from ispyb.connector.mysqlsp.main import ISPyBMySQLSPConnector as Connector

This imports ispyb.interface.connection:

import ispyb.interface.connection

and this imports ispyb.model:

import ispyb.model.interface

Thus, you cannot use ispyb.open without getting the warning:

warnings.warn(
"ispyb.model has been deprecated and will be removed in a future version. "
"You can use the SQLAlchemy models in ispyb.sqlalchemy instead",
DeprecationWarning,
stacklevel=2,
)

Are all non-sqlalchemy connection deprecated, or just ispyb.model? (AFAIK the sqlalchemy credentials don't have stored procedure access or insertion/update permissions, to get the same results - the credentials I am aware of can only see the update_session_archived procedure)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions