From 95e905099da783c67db2667c8b95b9049bd1033f Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 13 Aug 2026 21:43:14 +0000 Subject: [PATCH] Remove GarminDevices component GarminDevices rendered nothing in practice (Garmin exposes no connected device list), so remove the container component along with its story and preview data, its container export, and its usage in GarminView, DeviceDataView, and ConnectDevicesView. Co-Authored-By: Claude Opus 4.8 Claude-Session: https://claude.ai/code/session_01GWyazgMytMPbkK8sVEb4nv --- .../GarminDevices.previewdata.tsx | 20 ----------- .../GarminDevices/GarminDevices.stories.tsx | 35 ------------------- .../container/GarminDevices/GarminDevices.tsx | 13 ------- .../container/GarminDevices/index.ts | 1 - src/components/container/index.ts | 1 - .../ConnectDevicesView/ConnectDevicesView.tsx | 5 +-- .../view/DeviceDataView/DeviceDataView.tsx | 5 +-- .../view/GarminView/GarminView.stories.tsx | 3 -- src/components/view/GarminView/GarminView.tsx | 7 +--- 9 files changed, 3 insertions(+), 87 deletions(-) delete mode 100644 src/components/container/GarminDevices/GarminDevices.previewdata.tsx delete mode 100644 src/components/container/GarminDevices/GarminDevices.stories.tsx delete mode 100644 src/components/container/GarminDevices/GarminDevices.tsx delete mode 100644 src/components/container/GarminDevices/index.ts diff --git a/src/components/container/GarminDevices/GarminDevices.previewdata.tsx b/src/components/container/GarminDevices/GarminDevices.previewdata.tsx deleted file mode 100644 index e46eb7e40..000000000 --- a/src/components/container/GarminDevices/GarminDevices.previewdata.tsx +++ /dev/null @@ -1,20 +0,0 @@ -import { DeviceDataPoint } from "@careevolution/mydatahelps-js"; - -export var garminDevicePreviewData: DeviceDataPoint[] = - [ - { - "id": "1109644c-dea3-ec11-aaab-f47bb6835a10", - "namespace": "Garmin", - "insertedDate": "2022-03-14T21:32:51.413Z", - "modifiedDate": "2022-03-14T21:32:51.413Z", - "identifier": "806637943", - "type": "Device", - "value": "Forerunner 55", - "properties": { - "Battery": "High", - "Type": "TRACKER", - "DataLakeUrl": "https://pep-device-data-qa.s3.amazonaws.com/garmin-devices/d9134fe6-a777-ec11-aaa8-89aad5fbf200/devices.json" - }, - "observationDate": "2022-03-14T17:31:24+00:00" - } - ]; \ No newline at end of file diff --git a/src/components/container/GarminDevices/GarminDevices.stories.tsx b/src/components/container/GarminDevices/GarminDevices.stories.tsx deleted file mode 100644 index 326a8caff..000000000 --- a/src/components/container/GarminDevices/GarminDevices.stories.tsx +++ /dev/null @@ -1,35 +0,0 @@ -import React from "react" -import { ComponentStory, ComponentMeta } from "@storybook/react" -import GarminDevices, { GarminDevicesProps } from "./GarminDevices" -import Card from "../../presentational/Card" -import Layout from "../../presentational/Layout" - -export default { - title: "Container/GarminDevices", - component: GarminDevices, - parameters: { - layout: 'fullscreen', - } -} as ComponentMeta; - -const Template: ComponentStory = (args: GarminDevicesProps) => - - - - - ; - -export const NotEnabled = Template.bind({}); -NotEnabled.args = { - previewState: "notEnabled" -}; - -export const NotConnected = Template.bind({}); -NotConnected.args = { - previewState: "notConnected" -}; - -export const Connected = Template.bind({}); -Connected.args = { - previewState: "connected" -}; \ No newline at end of file diff --git a/src/components/container/GarminDevices/GarminDevices.tsx b/src/components/container/GarminDevices/GarminDevices.tsx deleted file mode 100644 index 78b9f2573..000000000 --- a/src/components/container/GarminDevices/GarminDevices.tsx +++ /dev/null @@ -1,13 +0,0 @@ -import React from 'react' -import { garminDevicePreviewData } from './GarminDevices.previewdata'; -import '@fortawesome/fontawesome-svg-core/styles.css'; -import ConnectedDevices, { ConnectedDevicesPreviewState } from '../ConnectedDevices/ConnectedDevices'; - -export interface GarminDevicesProps { - previewState?: ConnectedDevicesPreviewState; - innerRef?: React.Ref -} - -export default function (props: GarminDevicesProps) { - return (); -} diff --git a/src/components/container/GarminDevices/index.ts b/src/components/container/GarminDevices/index.ts deleted file mode 100644 index 617a6a869..000000000 --- a/src/components/container/GarminDevices/index.ts +++ /dev/null @@ -1 +0,0 @@ -export { default } from "./GarminDevices"; \ No newline at end of file diff --git a/src/components/container/index.ts b/src/components/container/index.ts index 3ae1e8d73..7497caad9 100644 --- a/src/components/container/index.ts +++ b/src/components/container/index.ts @@ -27,7 +27,6 @@ export { default as ExternalAccountsLoadingIndicator } from "./ExternalAccountsL export { default as ExternalAccountsPreview } from "./ExternalAccountsPreview" export { default as FitbitDevices } from "./FitbitDevices" export { default as FitbitMonthCharts } from "./FitbitMonthCharts" -export { default as GarminDevices } from "./GarminDevices" export { default as GarminMonthCharts } from "./GarminMonthCharts" export { default as GlucoseChart } from "./GlucoseChart" export { default as GlucoseDayCoordinator, GlucoseContext, GlucoseDayCoordinatorPreviewState } from "./GlucoseDayCoordinator" diff --git a/src/components/view/ConnectDevicesView/ConnectDevicesView.tsx b/src/components/view/ConnectDevicesView/ConnectDevicesView.tsx index e748d25b9..4ef940fdc 100644 --- a/src/components/view/ConnectDevicesView/ConnectDevicesView.tsx +++ b/src/components/view/ConnectDevicesView/ConnectDevicesView.tsx @@ -1,6 +1,6 @@ import React from 'react' import { BlankView, Card } from "../.." -import { ConnectDevicesMenu, FitbitDevices, GarminDevices, ViewDeviceActivity } from '../../container' +import { ConnectDevicesMenu, FitbitDevices, ViewDeviceActivity } from '../../container' import MyDataHelps from '@careevolution/mydatahelps-js' import standardDailyDataTypes from '../../../helpers/daily-data-types/standard' @@ -36,9 +36,6 @@ export default function ConnectDevicesView(props: ConnectDevicesViewProps) { - - - ) } \ No newline at end of file diff --git a/src/components/view/DeviceDataView/DeviceDataView.tsx b/src/components/view/DeviceDataView/DeviceDataView.tsx index 711463e6d..bbdea83f7 100644 --- a/src/components/view/DeviceDataView/DeviceDataView.tsx +++ b/src/components/view/DeviceDataView/DeviceDataView.tsx @@ -1,5 +1,5 @@ import React from 'react' -import { Layout, Card, StatusBarBackground, FitbitDevices, DeviceDataMonthCharts, GarminDevices, ConnectDevicesMenu } from "../.." +import { Layout, Card, StatusBarBackground, FitbitDevices, DeviceDataMonthCharts, ConnectDevicesMenu } from "../.." export interface DeviceDataViewProps { preview?: boolean; @@ -21,9 +21,6 @@ export default function DeviceDataView(props: DeviceDataViewProps) { - - - diff --git a/src/components/view/GarminView/GarminView.stories.tsx b/src/components/view/GarminView/GarminView.stories.tsx index f656f82ab..dddc1168a 100644 --- a/src/components/view/GarminView/GarminView.stories.tsx +++ b/src/components/view/GarminView/GarminView.stories.tsx @@ -19,7 +19,6 @@ const render = (args: GarminViewProps) => ; export const NotEnabled: Story = { args: { connectPreview: "notEnabled", - devicesPreview: "notEnabled", chartsPreview: "notEnabled" }, render: render @@ -28,7 +27,6 @@ export const NotEnabled: Story = { export const NotConnected: Story = { args: { connectPreview: "notConnected", - devicesPreview: "notConnected", chartsPreview: "notConnected" }, render: render @@ -37,7 +35,6 @@ export const NotConnected: Story = { export const Connected: Story = { args: { connectPreview: "fetchComplete", - devicesPreview: "connected", chartsPreview: "connected" }, render: render diff --git a/src/components/view/GarminView/GarminView.tsx b/src/components/view/GarminView/GarminView.tsx index 22226a6cf..2ede02bbe 100644 --- a/src/components/view/GarminView/GarminView.tsx +++ b/src/components/view/GarminView/GarminView.tsx @@ -1,13 +1,11 @@ import React, { useEffect, useState } from 'react' -import { Layout, Card, StatusBarBackground, ConnectGarmin, GarminDevices, GarminMonthCharts, LoadingIndicator } from "../.." +import { Layout, Card, StatusBarBackground, ConnectGarmin, GarminMonthCharts, LoadingIndicator } from "../.." import { ConnectGarminPreviewState } from "../../container/ConnectGarmin/ConnectGarmin"; -import { ConnectedDevicesPreviewState } from '../../container/ConnectedDevices/ConnectedDevices'; import { MonthChartsPreviewState } from '../../container/MonthCharts/MonthCharts'; import MyDataHelps from '@careevolution/mydatahelps-js'; export interface GarminViewProps { connectPreview?: ConnectGarminPreviewState, - devicesPreview?: ConnectedDevicesPreviewState, chartsPreview?: MonthChartsPreviewState, garminProviderID?: number } @@ -32,9 +30,6 @@ export default function GarminView(props: GarminViewProps) { - - -