Skip to content

Commit 620f8db

Browse files
fix(root): unblock express jobs in npmjs-release
#8650 introduced an `always()` chain on `release-bitgojs` so it can run when one of its two context jobs is skipped (get-release-context in recovery mode, get-recovery-context in normal mode). The Express jobs (get-express-release-context, publish-express-to-docker-hub) relied on GHA's implicit `success()` against `release-bitgojs`, which propagates the skipped context-job status as not-success along the chain. Express therefore skips on both modes even though release- bitgojs itself succeeded. Override with explicit `always() && needs.<>.result == 'success'` on both Express jobs so the docker publish runs whenever release-bitgojs actually succeeded, regardless of which context job ran. Ticket: WCN-357
1 parent b57c529 commit 620f8db

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/npmjs-release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ jobs:
318318
319319
get-express-release-context:
320320
name: Get Express release context
321-
if: inputs.dry-run == false
321+
if: ${{ always() && inputs.dry-run == false && needs.release-bitgojs.result == 'success' }}
322322
needs:
323323
- release-bitgojs
324324
runs-on: ${{ vars.BASE_RUNNER_TYPE || 'ubuntu-latest' }}
@@ -411,7 +411,7 @@ jobs:
411411
412412
publish-express-to-docker-hub:
413413
name: Publish Express To Docker Hub
414-
if: needs.get-express-release-context.outputs.docker-exists != 'true'
414+
if: ${{ always() && needs.get-express-release-context.result == 'success' && needs.get-express-release-context.outputs.docker-exists != 'true' }}
415415
needs:
416416
- get-express-release-context
417417
runs-on: ${{ vars.BASE_RUNNER_TYPE || 'ubuntu-latest' }}

0 commit comments

Comments
 (0)